Correctly append tar files for packaging#317
Merged
hemildesai merged 2 commits intomainfrom Aug 8, 2025
Merged
Conversation
samodi-nv
force-pushed
the
samodi/fix-mac-pkg
branch
from
1476bac to
8b889b9
Compare
Signed-off-by: Sahil Modi <samodi@nvidia.com>
samodi-nv
force-pushed
the
samodi/fix-mac-pkg
branch
from
8b889b9 to
1ed5c40
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Kipok
approved these changes
Aug 8, 2025
Contributor
Kipok
left a comment
Kipok
left a comment
There was a problem hiding this comment.
Thanks, I didn't check the logic, but verified that things work fine with this branch for nemo-skills
zoeyz101
pushed a commit
to zoeyz101/NeMo-Run
that referenced
this pull request
Nov 12, 2025
* Correctly append tar files for packaging Signed-off-by: Sahil Modi <samodi@nvidia.com> * tests Signed-off-by: Hemil Desai <hemild@nvidia.com> --------- Signed-off-by: Sahil Modi <samodi@nvidia.com> Signed-off-by: Hemil Desai <hemild@nvidia.com> Co-authored-by: Hemil Desai <hemild@nvidia.com> Signed-off-by: Zoey Zhang <zozhang@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #316. I have changed the method to gather the tar files first then concatenate at the very end, saving a lot of file IO on non-linux systems.