Add reservation_config support to LeptonExecutor#328
Closed
ansjindal wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Closed
Add reservation_config support to LeptonExecutor#328ansjindal wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
ansjindal wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Conversation
- Add reservation_config field to LeptonExecutor dataclass - Pass reservation_config from executor to job specification - Enable users to configure reservation settings for Lepton jobs Signed-off-by: ansjindal <ansjindal@nvidia.com>
ansjindal
force-pushed
the
feature/lepton-reservation-config
branch
from
e153be4 to
b984812
Compare
roclark
reviewed
Sep 3, 2025
Contributor
roclark
left a comment
roclark
left a comment
There was a problem hiding this comment.
Apologies I didn't see this earlier. One note about the type, but this would be great to have this update, thanks for creating it!
| lepton_job_dir: str = field(init=False, default="") | ||
| custom_spec: dict[str, Any] = field(default_factory=dict) | ||
| pre_launch_commands: list[str] = field(default_factory=list) # Custom commands before launch | ||
| reservation_config: Optional[dict[str, Any]] = None |
Contributor
There was a problem hiding this comment.
Should this be of type str instead of dict? Looking at the Lepton API it appears it just uses string.
Contributor
Author
|
looks like its already implemented as part of #336 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reservation_configfield toLeptonExecutordataclassreservation_configfrom executor to job specification