Skip to content

fix(typo): exit_code prints empty #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hemildesai merged 1 commit into from
Nov 10, 2025
Merged

fix(typo): exit_code prints empty #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nemo_run/core/execution/templates/slurm.sh.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ while ! $all_done; do
# Process is no longer running => check its exit status.
wait "$pid"
exitcode=$?
echo "Process $pid exited with code $exit_code at $(date '+%Y-%m-%d %H:%M:%S')"
echo "Process $pid exited with code $exitcode at $(date '+%Y-%m-%d %H:%M:%S')"
# Wait a bit (to get a clean stack trace in case there is one being generated), then kill the
# remaining processes if needed.
sleep {{monitor_group_job_wait_time}}
Expand Down
2 changes: 1 addition & 1 deletion test/core/execution/artifacts/ft_het_slurm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ while ! $all_done; do
# Process is no longer running => check its exit status.
wait "$pid"
exitcode=$?
echo "Process $pid exited with code $exit_code at $(date '+%Y-%m-%d %H:%M:%S')"
echo "Process $pid exited with code $exitcode at $(date '+%Y-%m-%d %H:%M:%S')"
# Wait a bit (to get a clean stack trace in case there is one being generated), then kill the
# remaining processes if needed.
sleep 60
Expand Down
2 changes: 1 addition & 1 deletion test/core/execution/artifacts/group_resource_req_slurm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ while ! $all_done; do
# Process is no longer running => check its exit status.
wait "$pid"
exitcode=$?
echo "Process $pid exited with code $exit_code at $(date '+%Y-%m-%d %H:%M:%S')"
echo "Process $pid exited with code $exitcode at $(date '+%Y-%m-%d %H:%M:%S')"
# Wait a bit (to get a clean stack trace in case there is one being generated), then kill the
# remaining processes if needed.
sleep 60
Expand Down
2 changes: 1 addition & 1 deletion test/core/execution/artifacts/group_slurm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ while ! $all_done; do
# Process is no longer running => check its exit status.
wait "$pid"
exitcode=$?
echo "Process $pid exited with code $exit_code at $(date '+%Y-%m-%d %H:%M:%S')"
echo "Process $pid exited with code $exitcode at $(date '+%Y-%m-%d %H:%M:%S')"
# Wait a bit (to get a clean stack trace in case there is one being generated), then kill the
# remaining processes if needed.
sleep 60
Expand Down
2 changes: 1 addition & 1 deletion test/core/execution/artifacts/het_slurm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ while ! $all_done; do
# Process is no longer running => check its exit status.
wait "$pid"
exitcode=$?
echo "Process $pid exited with code $exit_code at $(date '+%Y-%m-%d %H:%M:%S')"
echo "Process $pid exited with code $exitcode at $(date '+%Y-%m-%d %H:%M:%S')"
# Wait a bit (to get a clean stack trace in case there is one being generated), then kill the
# remaining processes if needed.
sleep 60
Expand Down
Loading