Open
Conversation
Collaborator
mckornfield
commented
Apr 1, 2026
mckornfield
commented
- make the slurm matrix/ run scripts take in an optional nss-version
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an option to run the Slurm experiment matrix using a published nemo-safe-synthesizer package version (via PyPI) instead of relying on a repo-based uv sync install, enabling faster/alternative dependency setup for cluster runs.
Changes:
- Add
--nss-versionflag to the Slurm submission script and export it into the job environment. - Update the Slurm matrix runner to conditionally install
nemo-safe-synthesizer==<version>into a versioned venv on Lustre and route executions through that install. - Switch the matrix runner to invoke the CLI via a configurable command (
NSS_RUN_CMD) for repo vs PyPI modes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| script/slurm/submit_slurm_jobs.sh | Adds CLI flag + help text and exports NSS_VERSION for downstream Slurm jobs. |
| script/slurm/slurm_nss_matrix.sh | Implements conditional PyPI install flow and uses NSS_RUN_CMD for train/generate/end-to-end runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mckornfield
force-pushed
the
allow-wheel-on-slurm/mck
branch
from
0b3bdb5 to
77694fc
Compare
mckornfield
force-pushed
the
allow-wheel-on-slurm/mck
branch
from
77694fc to
f6d32ca
Compare
mckornfield
force-pushed
the
allow-wheel-on-slurm/mck
branch
from
f6d32ca to
8e97076
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
mckornfield
force-pushed
the
allow-wheel-on-slurm/mck
branch
from
8e97076 to
3f0af94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.