feat: remove Job ID line from HTML report when N/A#350
Merged
alexahaushalter merged 3 commits intomainfrom Apr 3, 2026
Merged
Conversation
Signed-off-by: Alexa Haushalter <ahaushalter@nvidia.com>
nina-xu
previously approved these changes
Apr 3, 2026
Contributor
nina-xu
left a comment
There was a problem hiding this comment.
Look at you!!! 🎉 We have a open position on our team you know ;)
A few suggestions to make this PR a complete developer experience:
- Add a test to demonstrate the changed/fixed behavior. In this case, a test that asserts when there isn't a
NEMO_JOB_ID, thectx.job_idisNone; when there is a proper NEMO_JOB_ID, thectx.job_id` is the job ID - Run a quick job to demonstrate the report difference before/after. I typically use this config with the
clinc_oosdataset for the quickest result:
generation:
num_records: 500
training:
pretrained_model: TinyLlama/TinyLlama-1.1B-Chat-v1.0
num_input_records_to_sample: 1000
replace_pii: null
Anyhow, the code looks good and I'm OK with merging as is. Thanks!!
Signed-off-by: Alexa Haushalter <ahaushalter@nvidia.com>
nina-xu
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removing Job ID line from the HTML evaluation report when it does not exist. This is the case for library jobs.
Pre-Review Checklist
Ensure that the following pass:
make format && make checkor via prek validation.make testpasses locallymake test-e2epasses locallymake test-ci-containerpasses locally (recommended)/syncon this PR to trigger a run (auto-triggers on ready-for-review)Pre-Merge Checklist
Other Notes