Skip to content

feat: remove Job ID line from HTML report when N/A#350

Merged
alexahaushalter merged 3 commits intomainfrom
alexahaushalter/html-report-update
Apr 3, 2026
Merged

feat: remove Job ID line from HTML report when N/A#350
alexahaushalter merged 3 commits intomainfrom
alexahaushalter/html-report-update

Conversation

@alexahaushalter
Copy link
Copy Markdown
Contributor

@alexahaushalter alexahaushalter commented Apr 2, 2026

Summary

Removing Job ID line from the HTML evaluation report when it does not exist. This is the case for library jobs.

Pre-Review Checklist

Ensure that the following pass:

  • make format && make check or via prek validation.
  • make test passes locally
  • make test-e2e passes locally
  • make test-ci-container passes locally (recommended)
  • GPU CI status check passes -- comment /sync on this PR to trigger a run (auto-triggers on ready-for-review)

Pre-Merge Checklist

  • New or updated tests for any fix or new behavior
  • Updated documentation for new features and behaviors, including docstrings for API docs.

Other Notes

  • Closes #

Signed-off-by: Alexa Haushalter <ahaushalter@nvidia.com>
@alexahaushalter alexahaushalter requested a review from a team as a code owner April 2, 2026 20:23
@alexahaushalter alexahaushalter changed the title feat: remove Job ID line from HTML report when N/A feature: remove Job ID line from HTML report when N/A Apr 2, 2026
@alexahaushalter alexahaushalter changed the title feature: remove Job ID line from HTML report when N/A feat: remove Job ID line from HTML report when N/A Apr 2, 2026
nina-xu
nina-xu previously approved these changes Apr 3, 2026
Copy link
Copy Markdown
Contributor

@nina-xu nina-xu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at you!!! 🎉 We have a open position on our team you know ;)

A few suggestions to make this PR a complete developer experience:

  • Add a test to demonstrate the changed/fixed behavior. In this case, a test that asserts when there isn't a NEMO_JOB_ID, the ctx.job_id is None; when there is a proper NEMO_JOB_ID, the ctx.job_id` is the job ID
  • Run a quick job to demonstrate the report difference before/after. I typically use this config with the clinc_oos dataset for the quickest result:
generation:
  num_records: 500
training:
  pretrained_model: TinyLlama/TinyLlama-1.1B-Chat-v1.0
  num_input_records_to_sample: 1000
replace_pii: null

Anyhow, the code looks good and I'm OK with merging as is. Thanks!!

Signed-off-by: Alexa Haushalter <ahaushalter@nvidia.com>
@alexahaushalter alexahaushalter merged commit 88a915d into main Apr 3, 2026
10 checks passed
@alexahaushalter alexahaushalter deleted the alexahaushalter/html-report-update branch April 3, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants