Skip to content

Nemo-ASR models server [do not merge] #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jorjeous wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Nemo-ASR models server [do not merge] #1211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c33247
ASR models support
Jorjeous Feb 4, 2026
0d519ea
refactored code, added tar support s3 support nemo manifest support
Jorjeous Feb 20, 2026
b04fa5b
Merge origin/main into nemo-asr-server and resolve server enum conflict
Jorjeous Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions nemo_skills/inference/model/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@
# NIM models (speech)
from .asr_nim import ASRNIMModel

# NeMo models (speech)
from .nemo_asr import NemoASRModel
Comment on lines +23 to +24
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Fix import order to resolve the ruff-check pipeline failure.

The CI pipeline reports that ruff auto-fixed the file due to an import ordering violation. The .nemo_asr import is placed between .asr_nim and .audio_utils, but alphabetically it belongs after .megatron and before .openai. Commit the ruff-fixed version before merging.

🔧 Proposed fix – move the import to its sorted position 
-# NeMo models (speech)
-from .nemo_asr import NemoASRModel
-
 # Audio utilities
 from .audio_utils import (
     audio_file_to_base64,
     chunk_audio,
     load_audio_file,
     make_audio_content_block,
     save_audio_chunk_to_base64,
 )
 from .azure import AzureOpenAIModel
 ...
 from .megatron import MegatronModel
+from .nemo_asr import NemoASRModel
 from .openai import OpenAIModel
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@nemo_skills/inference/model/__init__.py` around lines 23 - 24, The import
order is wrong causing ruff to auto-fix; move the `from .nemo_asr import
NemoASRModel` line so imports are alphabetically sorted among the NeMo-related
imports (place `.nemo_asr` after `.megatron` and before `.openai`, keeping it
adjacent to other speech model imports like `.asr_nim`/`.audio_utils` as
appropriate) and commit the updated file so the ruff-check pipeline passes.


# Audio utilities
from .audio_utils import (
audio_file_to_base64,
Expand Down Expand Up @@ -65,6 +68,7 @@
"sglang": SGLangModel,
"tts_nim": TTSNIMModel,
"asr_nim": ASRNIMModel,
"nemo_asr": NemoASRModel,
}


Expand Down
Loading
Loading