[AIRE] fix(ci): resolve 3 bug(s) from PR #47 (run 30374248783) - #55
[AIRE] fix(ci): resolve 3 bug(s) from PR #47 (run 30374248783)#55svc-bcs-agent wants to merge 1 commit into
Conversation
|
/build |
|
Hi @hqtran-nv 👋💛 🤖✨ AIRE (NVIDIA's automated CI agent) here! ✨🤖 🔍🐛 I spotted 3 issues from the failing CI pipeline on your PR #47 🚨 🙏👀 Could you please help take a look and review it whenever you get a moment? 💬💚 💙🎉 Thanks so much for reviewing this PR from the AIRE agent! 💙🎉 |
00caa17 to
4a7e82f
Compare
|
/build |
4a7e82f to
8722ec5
Compare
svc-bcs-agent
changed the title
|
/build |
8722ec5 to
8700c64
Compare
svc-bcs-agent
changed the title
|
/build |
- g1: Fix bcq_openended schema mapping in MetropolisV3_0Validator to point to bcq_openended.schema.json instead of bcq.schema.json - g2: Fix cosmos-reason-v1.0 validator media path double-prefix (dataset_path / media_rel, not dataset_path / "media" / media_rel) - g3: Fix tao-vl-reason converter metadata.type to use the const "annotation" instead of the task_type variable Signed-off-by: svc-bcs-agent <svc-bcs-agent@nvidia.com>
8700c64 to
ec4204e
Compare
|
/build |
1 similar comment
|
/build |
|
Auto-retired by AIRE cleanup. The source pull request this fix targeted was CLOSED without merging, so this AIRE-authored fix PR is no longer wanted.
This AIRE PR was already closed; no retitle/close/branch-delete was performed (issue-only cleanup). |
|
Auto-retired by AIRE cleanup. The source pull request this fix targeted was CLOSED without merging, so this AIRE-authored fix PR is no longer wanted.
This AIRE PR was already closed; no re-close or branch delete was performed. |
|
Auto-retired by AIRE cleanup. The source pull request this fix targeted was CLOSED without merging, so this AIRE-authored fix PR is no longer wanted.
This AIRE PR was already closed; only the orphaned tracking issue required cleanup. |
|
Auto-retired by AIRE cleanup. The source pull request this fix targeted was CLOSED without merging, so this AIRE-authored fix PR is no longer wanted.
|
|
Auto-retired by AIRE cleanup. The source pull request this fix targeted was CLOSED without merging, so this AIRE-authored fix PR is no longer wanted.
This AIRE PR was already closed on GitHub; only the orphaned tracking issue required cleanup. |
|
Auto-retired by AIRE cleanup. The source pull request this fix targeted was CLOSED without merging, so this AIRE-authored fix PR is no longer wanted.
(This AIRE PR was already closed; no retitle/close/branch-delete was needed.) |
1 participant
Summary
Fixes 22 test failures from CI run 30374248783 on PR #47 (
ci/AIRE-test-2).Three independent regressions introduced in commit
6e48690:Bug 1:
bcq_openendedschema mapping (g1)File:
src/nvidia_tao_daft/validators/metropolis_v3_0/validator.py:82Root cause:
_TASK_SCHEMAS["bcq_openended"]pointed tobcq.schema.jsoninstead ofbcq_openended.schema.json, causing the validator to use the wrong schema (BCQ restricts answers to["Yes", "No"]enum; BCQ Open-Ended needs pattern-based answers).Fix: Correct the mapping to
"tasks/bcq_openended.schema.json".Tests fixed: 8
Bug 2: Cosmos Reason validator double
media/prefix (g2)File:
src/nvidia_tao_daft/validators/cosmos_reason_v1_0/validator.py:266Root cause: Media path resolved as
dataset_path / "media" / media_rel, butmedia_relalready contains themedia/prefix (schema enforces^media/.+), producingmedia/media/video_001.mp4.Fix: Use
dataset_path / media_rel(remove the extra"media" /segment).Tests fixed: 12
Bug 3: tao-vl-reason converter
metadata.type(g3)File:
src/nvidia_tao_daft/converters/pairs/metropolis_v3_0_to_tao_vl_reason_v1_0.py:493Root cause:
metadata.typeset totask_typevariable instead of the const"annotation"required by the tao-vl-reason schema discriminator.Fix: Restore
{"type": "annotation", "task": task_type}.Tests fixed: 2
Fixes #59
Signed-off-by: svc-bcs-agent svc-bcs-agent@nvidia.com