[TAO-2148][Feature] RADIO distillation: consume core KNN via re-export shim - #78
Open
vpraveen-nv wants to merge 2 commits into
Open
[TAO-2148][Feature] RADIO distillation: consume core KNN via re-export shim#78vpraveen-nv wants to merge 2 commits into
vpraveen-nv wants to merge 2 commits into
Conversation
|
For security reasons, CI does not run automatically on NVIDIA's runners — it must be triggered per commit.
Tip Should this fix also ship in a release? Add a Important Before merging: every file needs a license header and every commit must be DCO signed-off — see the 📖 Contribution guide for details. |
This was referenced Aug 5, 2026
Contributor
Author
|
/build |
vpraveen-nv
force-pushed
the
feature/core-eval-c
branch
from
August 7, 2026 16:39
115f687 to
a5da29e
Compare
…t shim Dependency inversion: radio/distillation/knn_classification.py becomes a thin re-export shim onto nvidia_tao_pytorch.core.evaluation.knn. The KNN vote math (distributed_topk, knn_top1_accuracy, _get_vote_cls) is now owned by the shared suite and merely relocated here, so existing imports keep working and the distillation KNN-top1 numbers are unchanged (validate.py + the distiller resolve to the same core objects). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Varun Praveen <vpraveen@nvidia.com>
Nested single quotes inside f-string replacement fields are only valid from Python 3.12 (PEP 701). CI lints on Python 3.11, so pylint/flake8 report a syntax error for any change set that touches or imports this module. Flip the outer quotes to double quotes; no behavior change. Signed-off-by: Varun Praveen <vpraveen@nvidia.com>
vpraveen-nv
force-pushed
the
feature/core-eval-c
branch
from
August 10, 2026 19:25
a5da29e to
8a641bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Dependency inversion for RADIO distillation:
radio/distillation/knn_classification.pybecomes a thin re-export shim onto the sharedcore.evaluation.knnmodule. The math is relocated, not modified —validate.pyand the distiller resolve to the same core objects.Why are the changes needed?
Part 3/5 of the shared
core/evaluationembedding-eval suite (epic TAO-2181). Removes a duplicated KNN implementation so SSL and RADIO families evaluate through one code path.Related issues
JIRA: TAO-2148 (parent epic TAO-2181). N/A for GitHub issues.
Does this PR introduce any user-facing change?
No — behavior-preserving refactor; distillation KNN-top1 unchanged.
How was this patch tested?
Covered by the stack's shared test suite (26 unit tests land in #80, including KNN vote math: FAISS + brute-force + online → 100% on separable data). Distillation KNN-top1 verified unchanged.
Was this patch authored or co-authored using generative AI tooling?
Yes
Release note
Checklist
git commit -s) — seeCONTRIBUTING.mdso the package still works without them (reviewers: please verify this)
my commit author name and email become permanently public once merged
Notes for reviewers
Review the core-eval stack in order: #78 → #79 → #80 → #81 (this is part 3/5; parts 1–2 merged on GitLab before migration).
Migrated from GitLab MR nvidia-tao-toolkit/tao-pytorch!616, rebased onto GitHub
main.