Skip to content

Track split_megabytes in wandb.#2629

Open
yobibyte wants to merge 2 commits intoNVIDIA:mainfrom
yobibyte:split_bytes
Open

Track split_megabytes in wandb.#2629
yobibyte wants to merge 2 commits intoNVIDIA:mainfrom
yobibyte:split_bytes

Conversation

@yobibyte
Copy link
Contributor

@yobibyte yobibyte commented Dec 11, 2025

What does this PR do ?

This PR adds tracking the amount of split blocks from pytorch stats. Those will help us to identify issues with memory fragmentation.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@yobibyte yobibyte requested a review from a team as a code owner December 11, 2025 12:10
@ko3n1g ko3n1g added this to the Core 0.16 milestone Dec 11, 2025
@yobibyte yobibyte added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Dec 11, 2025
@yobibyte yobibyte enabled auto-merge December 11, 2025 14:10
@yobibyte
Copy link
Contributor Author

/ok to test 7028f41

@yaox12 yaox12 disabled auto-merge February 2, 2026 06:46
@yaox12 yaox12 enabled auto-merge February 2, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants