Skip to content

fix(moe): improve error message for GroupedMLP FP8 support #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liuyun7345 wants to merge 6 commits into
base: main
Choose a base branch
from
+6 −1
Open

fix(moe): improve error message for GroupedMLP FP8 support #3015

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3c838f4
fix(moe): improve error message for GroupedMLP FP8 support
liuyun7345 Jan 20, 2026
9ce23e1
Update experts.py
yaox12 Jan 21, 2026
945ecce
Update experts.py
yaox12 Jan 21, 2026
f74eee2
Merge branch 'main' into fix/improve-grouped-mlp-fp8-error-message
yaox12 Jan 21, 2026
b5b9a55
Merge branch 'main' into fix/improve-grouped-mlp-fp8-error-message
liuyun7345 Jan 22, 2026
da66c05
Merge branch 'main' into fix/improve-grouped-mlp-fp8-error-message
liuyun7345 Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion megatron/core/transformer/moe/experts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,12 @@ def forward(
permuted_probs: torch.Tensor,
):
"""Forward step of the GroupedMLP."""
assert self.config.bf16, "Currently GroupedMLP for MoE only supports bf16."
assert self.config.bf16, (
"The legacy GroupedMLP only supports bf16. "
"For FP16/FP8 support, please use TEGroupedMLP instead, which is adopted by default "
"when TransformerEngine >= 1.9 is installed and '--moe-use-legacy-grouped-gemm' is "
"*not* set."
)
if self.activation_recompute:
self.activation_checkpoint = tensor_parallel.CheckpointWithoutOutput()

Expand Down