Skip to content

Reset AG_pipeline bucket status after validation step.#3155

Draft
vasunvidia wants to merge 1 commit intoNVIDIA:mainfrom
vasunvidia:vrengasamy/fsdp_cg_val_fix2
Draft

Reset AG_pipeline bucket status after validation step.#3155
vasunvidia wants to merge 1 commit intoNVIDIA:mainfrom
vasunvidia:vrengasamy/fsdp_cg_val_fix2

Conversation

@vasunvidia
Copy link
Contributor

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@vasunvidia vasunvidia requested review from a team as code owners January 29, 2026 22:32
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 29, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ko3n1g ko3n1g requested a review from a team January 29, 2026 22:33
@erhoo82 erhoo82 added this to the Core 0.16 milestone Jan 29, 2026
@erhoo82 erhoo82 added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Jan 29, 2026
model_chunk.ddp_config.overlap_param_gather
and model_chunk.ddp_config.use_megatron_fsdp
):
model_chunk.start_param_sync(sync_and_return=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can start_param_sync(sync_and_return=True) be replaced with synchronize_param_gather here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I tried that. But it is not possible because it's not part of FullyShardedDataParallel class. We need to call synchronize_param_gather within start_param_sync

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, could you try putting the synchronize_param_gather function on FullyShardedDataParallel(example)? The goal is to help keep the start_param_sync function simple, thank you.

@dimapihtar dimapihtar requested review from erhoo82 and yanring February 4, 2026 15:27
@dimapihtar
Copy link
Contributor

/ok to test 1be259b

@vasunvidia vasunvidia force-pushed the vrengasamy/fsdp_cg_val_fix2 branch from 1be259b to b4bef4f Compare March 18, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: low Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants