Separate save_checkpoint into per-type execution paths#3852
Open
Anmol202005 wants to merge 1 commit intoNVIDIA:mainfrom
Open
Separate save_checkpoint into per-type execution paths#3852Anmol202005 wants to merge 1 commit intoNVIDIA:mainfrom
Anmol202005 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Separate
save_checkpointinto per-type helper functions by extracting_save_legacy_checkpoint,_save_local_checkpoint,_save_global_dist_checkpoint, and_save_global_dcp_checkpointas standalone top-level functions.Part of #3758.
Pre-checks