Skip to content

Allow untokenized messages when using the prevent tokenization mode.#3864

Open
ArEsKay3 wants to merge 2 commits intoNVIDIA:mainfrom
ArEsKay3:rkirby/allow_untokenized_when_using_prevent
Open

Allow untokenized messages when using the prevent tokenization mode.#3864
ArEsKay3 wants to merge 2 commits intoNVIDIA:mainfrom
ArEsKay3:rkirby/allow_untokenized_when_using_prevent

Conversation

@ArEsKay3
Copy link
Contributor

What does this PR do ?

Need to allow for the case that the incoming request doesn't have any previous tokenization metadata and just do tokenization normally even when "prevent_retokenization" is true.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 13, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@santhnm2
Copy link
Contributor

@ArEsKay3 This is different than the issue fixed in #3862 right?

@ArEsKay3 ArEsKay3 marked this pull request as ready for review March 17, 2026 05:41
@ArEsKay3 ArEsKay3 requested review from a team as code owners March 17, 2026 05:41
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 17, 2026 05:41
@santhnm2
Copy link
Contributor

LGTM but might be redundant with !3862, @i-riyad could you comment here?

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: low Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants