Skip to content

[main][fix] Add TE's attribute to check if offloading tensor #3896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lhb8125 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[main][fix] Add TE's attribute to check if offloading tensor #3896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions megatron/core/pipeline_parallel/fine_grained_activation_offload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,6 +867,8 @@ def tensor_need_offloading_checker(self, tensor):
# Respect tensor's offload preference if specified
if hasattr(tensor, "offloading_activation") and not tensor.offloading_activation:
return False
if getattr(tensor, "_TE_do_not_offload", False):
return False
return True

def bulk_offload_group(self):
Expand Down
Loading