Skip to content

Add common pile scripts#3902

Open
Phlip79 wants to merge 6 commits intoNVIDIA:mainfrom
Phlip79:philip/common-pile
Open

Add common pile scripts#3902
Phlip79 wants to merge 6 commits intoNVIDIA:mainfrom
Phlip79:philip/common-pile

Conversation

@Phlip79
Copy link
Member

@Phlip79 Phlip79 commented Mar 17, 2026

What does this PR do ?

Adding instructions and scripts used to create common pile dataset for CI testing.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 17, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Phlip79 Phlip79 marked this pull request as ready for review March 17, 2026 18:16
@Phlip79
Copy link
Member Author

Phlip79 commented Mar 17, 2026

/ok to test 992193b

@Phlip79
Copy link
Member Author

Phlip79 commented Mar 17, 2026

/claude review

@Phlip79
Copy link
Member Author

Phlip79 commented Mar 17, 2026

/claude review

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
@Phlip79
Copy link
Member Author

Phlip79 commented Mar 17, 2026

/ok to test 548f2d2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants