Skip to content

ci: Fix build-and-test-wheels jobs for arm#3910

Merged
chtruong814 merged 2 commits intoNVIDIA:mainfrom
chtruong814:chtruong/fix-wheel-build
Mar 18, 2026
Merged

ci: Fix build-and-test-wheels jobs for arm#3910
chtruong814 merged 2 commits intoNVIDIA:mainfrom
chtruong814:chtruong/fix-wheel-build

Conversation

@chtruong814
Copy link
Contributor

@chtruong814 chtruong814 commented Mar 17, 2026

What does this PR do ?

ci: Fix build-and-test-wheels jobs for arm

This PR merged that broke the build-and-test-wheels tests.
#3858

The arm build and test job failed because we did not have import guards around triton.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

cspades and others added 2 commits March 17, 2026 18:37
Signed-off-by: Cory Ye <cye@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 requested review from a team as code owners March 17, 2026 23:44
@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft March 17, 2026 23:44
@github-actions
Copy link
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 17, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Mar 17, 2026
@chtruong814 chtruong814 marked this pull request as ready for review March 17, 2026 23:44
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 17, 2026 23:44
Copy link
Member

@cspades cspades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@chtruong814
Copy link
Contributor Author

Moving forward with fast merging to unblock merges to main

@chtruong814 chtruong814 merged commit c058fc0 into NVIDIA:main Mar 18, 2026
53 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants