Remove examples/diffusers/eval example#1694
Conversation
The diffusers image-quality eval scripts (ImageReward/CLIP-IQA/CLIP) are no longer maintained. Delete examples/diffusers/eval/ and drop the now-dangling "Evaluate Accuracy" references from examples/diffusers/README.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Jingyu Xin <jingyux@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe Diffusers example documentation is updated to remove evaluation feature references. The README intro, navigation table, and installation guidance are modified to eliminate mentions of evaluation. The complete "Evaluate Accuracy" section is deleted from the document. A deprecation entry is added to the changelog. ChangesDiffusers evaluation documentation removal
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1694 +/- ##
==========================================
- Coverage 77.12% 77.10% -0.02%
==========================================
Files 511 511
Lines 56236 56236
==========================================
- Hits 43370 43359 -11
- Misses 12866 12877 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/ok to test f352498 |
|
@jingyu-ml please update Changelog to mention removal of this example |
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Jingyu Xin <jingyux@nvidia.com>
What does this PR do?
Type of change: Documentation / example removal
Removes the unmaintained
examples/diffusers/eval/image-quality evaluation example (ImageReward / CLIP-IQA / CLIP metrics), which is no longer maintained. Also cleans up the now-dangling references to it inexamples/diffusers/README.md:requirements.txtnote (example updated fromevaltofastgen, distillation),Scope is intentionally limited to the diffusers example. The unrelated
examples/llm_ptq"Evaluate Accuracy" section is not touched.Usage
N/A — this removes example scripts; there are no library API changes.
Testing
N/A — deletion of example scripts plus documentation cleanup. Verified that
examples/diffusers/README.mdhas no remaining references to the deletedeval/directory, no broken section anchors, no trailing whitespace, and the final newline is intact.Before your PR is "Ready for review"
examples/diffusers/eval/; no publicmodeloptAPI is affected.CONTRIBUTING.md: N/A — no code copied; this removes the example's ownrequirements.txt.Additional Information
Deletes
examples/diffusers/eval/(5 files) and trims its references from the diffusers README.🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes