Skip to content

fix(puzzletron): correct val_dataset_name from 'valid' to 'validation'#1765

Open
TheSabari07 wants to merge 1 commit into
NVIDIA:mainfrom
TheSabari07:fix/puzzletron-val-dataset-name
Open

fix(puzzletron): correct val_dataset_name from 'valid' to 'validation'#1765
TheSabari07 wants to merge 1 commit into
NVIDIA:mainfrom
TheSabari07:fix/puzzletron-val-dataset-name

Conversation

@TheSabari07

@TheSabari07 TheSabari07 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

The validate_model_defaults.yaml file has val_dataset_name set to valid, but it should be validation per the dataset split expected by the tutorial configuration.

This causes the Puzzletron tutorial to fail at the subblock scoring step (6/8).

What does this PR do?

Type of change: Bug fix

Updates the Puzzletron validation config to use the correct validation dataset split name:

  • val_dataset_name: validval_dataset_name: validation

This fixes the tutorial configuration so the pipeline can proceed correctly during the validation/subblock scoring stage.

Usage

No user-facing API changes. This is a config fix for the existing Puzzletron tutorial.

Testing

Verified the YAML config was updated to use the correct dataset split name.

Before your PR is "Ready for review"

Make sure you read and follow Contributor guidelines and your commits are signed (git commit -s -S).

Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded trust_remote_code=True, torch.load(..., weights_only=False), pickle, etc.).

  • Is this change backward compatible?: ✅
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: N/A
  • Did you write any new necessary tests?: N/A
  • Did you update Changelog?: N/A
  • Did you get Claude approval on this PR?: N/A

Additional Information

This addresses the tutorial failure at step 6/8 caused by the incorrect dataset split name in:

examples/puzzletron/configs/llama-3_1-8B_pruneffn_memory/validate_model_defaults.yaml

Summary by CodeRabbit

  • Bug Fixes
    • Updated default validation dataset configuration parameter to correct dataset identifier.

The validate_model_defaults.yaml has val_dataset_name set to 'valid'
but it should be 'validation' per the dataset API.

This causes the tutorial to fail at the sublock scoring step (6/8).

Signed-off-by: Sabari07 <sabursd18@gmail.com>
@TheSabari07 TheSabari07 requested a review from a team as a code owner June 17, 2026 16:32
@copy-pr-bot

copy-pr-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e642342d-9438-42b3-8c8b-f6595b43fb17

📥 Commits

Reviewing files that changed from the base of the PR and between 769ea5f and a7184b3.

📒 Files selected for processing (1)
  • examples/puzzletron/configs/llama-3_1-8B_pruneffn_memory/validate_model_defaults.yaml

📝 Walkthrough

Walkthrough

The val_dataset_name default value in validate_model_defaults.yaml for the llama-3.1-8B pruning example is changed from valid to validation. No other fields are modified.

Changes

Validation dataset name correction

Layer / File(s) Summary
Correct val_dataset_name default
examples/puzzletron/configs/llama-3_1-8B_pruneffn_memory/validate_model_defaults.yaml
Changes the val_dataset_name default from valid to validation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/Model-Optimizer#1729: Directly related — modifies the same val_dataset_name field in the same config file, setting the value to valid (the value being reverted by this PR).

Suggested reviewers

  • danielkorzekwa
  • kevalmorabia97
🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately describes the main change: correcting val_dataset_name from 'valid' to 'validation' in the puzzletron configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Security Anti-Patterns ✅ Passed PR contains only a YAML configuration file change (dataset name update), no Python code modifications, dependencies, or security-sensitive patterns.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant