fix(puzzletron): correct val_dataset_name from 'valid' to 'validation'#1765
Open
TheSabari07 wants to merge 1 commit into
Open
fix(puzzletron): correct val_dataset_name from 'valid' to 'validation'#1765TheSabari07 wants to merge 1 commit into
TheSabari07 wants to merge 1 commit into
Conversation
The validate_model_defaults.yaml has val_dataset_name set to 'valid' but it should be 'validation' per the dataset API. This causes the tutorial to fail at the sublock scoring step (6/8). Signed-off-by: Sabari07 <sabursd18@gmail.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesValidation dataset name correction
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
validate_model_defaults.yamlfile hasval_dataset_nameset tovalid, but it should bevalidationper the dataset split expected by the tutorial configuration.This causes the Puzzletron tutorial to fail at the subblock scoring step (6/8).
What does this PR do?
Type of change: Bug fix
Updates the Puzzletron validation config to use the correct validation dataset split name:
val_dataset_name: valid→val_dataset_name: validationThis fixes the tutorial configuration so the pipeline can proceed correctly during the validation/subblock scoring stage.
Usage
No user-facing API changes. This is a config fix for the existing Puzzletron tutorial.
Testing
Verified the YAML config was updated to use the correct dataset split name.
Before your PR is "Ready for review"
Make sure you read and follow Contributor guidelines and your commits are signed (
git commit -s -S).Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded
trust_remote_code=True,torch.load(..., weights_only=False),pickle, etc.).CONTRIBUTING.md: N/AAdditional Information
This addresses the tutorial failure at step 6/8 caused by the incorrect dataset split name in:
examples/puzzletron/configs/llama-3_1-8B_pruneffn_memory/validate_model_defaults.yamlSummary by CodeRabbit