Skip to content

Make generated ids unique across processes #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AjayThorve merged 1 commit into from
Jun 23, 2026
Merged

Make generated ids unique across processes #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/fabric-core/src/runtime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1547,8 +1547,12 @@ fn event_with_metadata(
}

fn new_id(prefix: &str) -> String {
// The atomic counter only differentiates ids within a single process; a
// process-backed runner spawns a fresh `fabric-cli` per call, resetting it
// to 1. Include the process id (distinct across concurrently running
// processes) so ids stay unique when two runs land in the same millisecond.
let counter = NEXT_ID.fetch_add(1, Ordering::Relaxed);
format!("{prefix}-{}-{counter}", now_millis())
format!("{prefix}-{}-{}-{counter}", now_millis(), std::process::id())
}

fn now_millis() -> u128 {
Expand Down