Skip to content

fix: reject colliding tool definition extensions #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 1 commit into from
Aug 14, 2026
Merged

fix: reject colliding tool definition extensions #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion python/src/nemo_fabric/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,11 +982,18 @@ def add_definition(

if not name.strip():
raise ValueError("tool definition names must not be empty")
extras = dict(extra_fields or {})
overlap = {"kind", "ref", "settings"}.intersection(extras)
if overlap:
raise ValueError(
"extra_fields duplicates known fields: "
+ ", ".join(sorted(overlap))
)
value = {
"kind": kind,
"ref": ref,
"settings": dict(settings or {}),
**dict(extra_fields or {}),
**extras,
}
self.definitions[name] = ToolDefinitionConfig.model_validate(value)
return self
Expand Down
13 changes: 13 additions & 0 deletions tests/python/test_sdk_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,6 +763,19 @@ def test_typed_tool_definition_omits_empty_settings():
}


@pytest.mark.parametrize("field", ["kind", "ref", "settings"])
def test_typed_tool_definition_rejects_known_extra_field_collisions(field: str):
tools = ToolsConfig()

with pytest.raises(ValueError, match="extra_fields duplicates known fields"):
tools.add_definition(
"web",
kind="function_group",
ref="web_tools",
extra_fields={field: "replacement"},
)


def test_run_plan_snapshot_removes_named_definition():
config = _FabricConfigSnapshot.from_mapping(
{
Expand Down
Loading