ci: isolate docs dependency sync - #237
Conversation
Signed-off-by: Ajay Thorve <athorve@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (20)
🧰 Additional context used📓 Path-based instructions (3)**/*📄 CodeRabbit inference engine (.agents/skills/karpathy-guidelines/SKILL.md)
Files:
{pyproject.toml,justfile}📄 CodeRabbit inference engine (.agents/skills/contribute-adapter/SKILL.md)
Files:
justfile📄 CodeRabbit inference engine (.agents/skills/maintain-ci/SKILL.md)
Files:
🔇 Additional comments (1)
WalkthroughThe ChangesDocumentation dependency synchronization
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized documentation build change is merge-ready after normal checks and review; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/merge |
|
Fern docs preview: https://nvidia-preview-pull-request-237.docs.buildwithfern.com/nemo/fabric |
Overview
Make the docs recipe install only the locked documentation dependency group. This prevents docs builds from resolving the default adapter group and requiring the optional
external/hermes-agentcheckout.Details
--frozenso uv consumes the committed lockfile without resolving the absent editable Hermes source.--no-default-groupsso docs builds do not install adapter and test dependencies.just docsrecipe so preview, post-merge, release, and local docs builds use the same behavior.Validation
just docsin a pristine worktree.just docssuccessfully from a clean checkout with noexternal/hermes-agentdirectory.just --set no_uv true docssuccessfully as a final generation and Fern validation pass.just --fmt --checkandgit diff --check.FERN_TOKENwas supplied locally.Where should the reviewer start?
justfile: thedocsrecipe dependency sync.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Relates to: chore: Switch to hermes-agent v0.20.1 #234
I confirm this contribution is my own work, or I have the right to submit it under this project's license.
I searched existing issues and open pull requests, and this does not duplicate existing work.
Summary by CodeRabbit