Skip to content

ci: isolate docs dependency sync - #237

Merged
rapids-bot[bot] merged 1 commit into
mainfrom
fix/docs-hermes-source-sync
Aug 14, 2026
Merged

ci: isolate docs dependency sync#237
rapids-bot[bot] merged 1 commit into
mainfrom
fix/docs-hermes-source-sync

Conversation

@AjayThorve

@AjayThorve AjayThorve commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Overview

Make the docs recipe install only the locked documentation dependency group. This prevents docs builds from resolving the default adapter group and requiring the optional external/hermes-agent checkout.

Details

  • Add --frozen so uv consumes the committed lockfile without resolving the absent editable Hermes source.
  • Add --no-default-groups so docs builds do not install adapter and test dependencies.
  • Keep the fix in the shared just docs recipe so preview, post-merge, release, and local docs builds use the same behavior.

Validation

  • Reproduced the merged-main failure with just docs in a pristine worktree.
  • Ran just docs successfully from a clean checkout with no external/hermes-agent directory.
  • Ran just --set no_uv true docs successfully as a final generation and Fern validation pass.
  • Ran just --fmt --check and git diff --check.
  • Fern reported only the expected unauthenticated missing-redirects warning because no FERN_TOKEN was supplied locally.

Where should the reviewer start?

justfile: the docs recipe dependency sync.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • Relates to: chore: Switch to hermes-agent v0.20.1 #234

  • I confirm this contribution is my own work, or I have the right to submit it under this project's license.

  • I searched existing issues and open pull requests, and this does not duplicate existing work.

Summary by CodeRabbit

  • Chores
    • Updated documentation setup to use a locked dependency configuration, improving consistency and reproducibility when installing documentation dependencies.

Signed-off-by: Ajay Thorve <athorve@nvidia.com>
@AjayThorve
AjayThorve requested a review from a team as a code owner August 14, 2026 23:31
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 3135651b-9a47-44f7-8b91-73c378478469

📥 Commits

Reviewing files that changed from the base of the PR and between 645ca47 and 84e329a.

📒 Files selected for processing (1)
  • justfile
📜 Recent review details
⏰ Context from checks skipped due to timeout. (20)
  • GitHub Check: Preview docs
  • GitHub Check: Test (Python 3.11, windows-amd64)
  • GitHub Check: Test (arm64)
  • GitHub Check: Test (Python 3.14, macos-arm64)
  • GitHub Check: Test (Python 3.13, macos-arm64)
  • GitHub Check: Test (Python 3.13, linux-amd64)
  • GitHub Check: Test (Python 3.12, linux-arm64)
  • GitHub Check: Test (Python 3.13, linux-arm64)
  • GitHub Check: Test (Python 3.14, windows-amd64)
  • GitHub Check: Test (Python 3.12, windows-amd64)
  • GitHub Check: Test (Python 3.13, windows-amd64)
  • GitHub Check: Test (Python 3.14, linux-amd64)
  • GitHub Check: Test (Python 3.12, linux-amd64)
  • GitHub Check: Test (Python 3.14, linux-arm64)
  • GitHub Check: Test (Python 3.12, macos-arm64)
  • GitHub Check: Test (Python 3.11, linux-arm64)
  • GitHub Check: Test (Python 3.11, linux-amd64)
  • GitHub Check: Test (x86_64)
  • GitHub Check: Test (Python 3.11, macos-arm64)
  • GitHub Check: Pre-commit
🧰 Additional context used
📓 Path-based instructions (3)
**/*

📄 CodeRabbit inference engine (.agents/skills/karpathy-guidelines/SKILL.md)

**/*: Before implementing, explicitly state assumptions, surface ambiguity and tradeoffs, present multiple interpretations when relevant, and ask for clarification rather than silently deciding or proceeding when requirements are unclear.
Prefer the minimum code needed to solve the requested problem: avoid speculative features, unnecessary abstractions, unrequested flexibility, and handling of impossible scenarios; simplify overcomplicated solutions.
When editing existing code, make surgical changes only: do not modify unrelated code, comments, formatting, or pre-existing dead code; match the existing style, and remove only unused imports, variables, or functions introduced by your changes.
Define verifiable success criteria for each task, such as writing regression tests for bugs and invalid-input tests for validation, then verify the implementation against those criteria. For multi-step work, state a brief plan with a verification check for each step.

**/*: Always spell NVIDIA in all caps; do not use Nvidia, nvidia, nVidia, nVIDIA, or NV.
Use an NVIDIA before a noun, because the name begins with an “en” sound.
Do not add a registered trademark symbol after NVIDIA when referring to the company; use trademark symbols with product names only when required by the document type or legal guidance.
Verify official capitalization, spacing, hyphenation, and spelling for NVIDIA and third-party product names; do not rewrite official product names for grammar or title-case rules.
Precede NVIDIA product names with NVIDIA on first mention when natural and accurate, and link the first mention when the destination helps the reader.
On first use, include the company name and full model qualifier when it helps identify the model; preserve official capitalization and punctuation, and use shorter family names only after establishing the full name.
For learning-oriented and developer content, do not force trademark symbols unless explicitly required; for press, ...

Files:

  • justfile
{pyproject.toml,justfile}

📄 CodeRabbit inference engine (.agents/skills/contribute-adapter/SKILL.md)

{pyproject.toml,justfile}: Add the package to the root adapter-test dependency group,
[tool.uv.sources], python_projects in justfile, applicable catalogs,
and CI enumerations. Ship its descriptor under
share/nemo-fabric/adapters/<name>.

Files:

  • justfile
justfile

📄 CodeRabbit inference engine (.agents/skills/maintain-ci/SKILL.md)

just --fmt --check

Files:

  • justfile
🔇 Additional comments (1)
justfile (1)

412-412: LGTM!


Walkthrough

The docs target now uses uv sync --frozen --no-default-groups --group docs when dependency synchronization is enabled.

Changes

Documentation dependency synchronization

Layer / File(s) Summary
Update docs synchronization command
justfile
The docs target now performs frozen synchronization for the docs dependency group without default groups.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 84e32

This localized documentation build change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title uses the allowed Conventional Commits format, an imperative summary, lowercase type, and no trailing period.
Description check ✅ Passed The description includes the required overview, reviewer starting point, related issue, contribution confirmation, and duplicate-work confirmation.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/docs-hermes-source-sync

Comment @coderabbitai help to get the list of available commands.

@AjayThorve

Copy link
Copy Markdown
Collaborator Author

/merge

@rapids-bot
rapids-bot Bot merged commit 7218f18 into main Aug 14, 2026
34 checks passed
@github-actions

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants