Forward-merge release/0.2 into main - #243
Merged
Merged
Conversation
#### Overview Repairs beta/RC publication so release branches keep stable base versions while tag workflows stamp prerelease metadata only in disposable workflow checkouts. The `v0.2.0-rc.1` Rust workflow called the project-wide version setter, which unnecessarily entered Python locking and failed because the publication checkout did not contain the Hermes submodule. The TypeScript workflow correctly produced tag-time metadata changes, then rejected those expected changes with `git diff --exit-code`. #### Where should the reviewer start? Start with `.github/workflows/publish_rust.yml` and the new `set-cargo-version` recipe in `justfile`, then review `.github/workflows/publish_typescript.yml` and the clarified prerelease model in `RELEASING.md`. #### Details - Add a narrow Cargo-only tag-time version setter that avoids unrelated Python and TypeScript locking. - Shell-quote release tag inputs before Just interpolates them into publication commands. - Allow expected TypeScript manifest and lockfile changes in the disposable publication checkout. - Publish Rust crates with the stamped lockfile and wait up to two minutes for the core crate to become registry-visible before publishing the dependent CLI crate. - Document that release branches retain stable versions such as `0.2.0`; RC-specific versions and internal pins are derived from tags and are never committed. #### Validation - `just --fmt --check` - Release tag normalization/version tests: 23 passed - Release tag interpolation regression tests: 14 targeted tests passed across the new quoting coverage and tag normalizer - `cargo check --workspace --locked` - Core crate `cargo publish --dry-run --locked --no-verify --allow-dirty` after disposable RC2 stamping - Python release build after disposable RC2 stamping - Node 22 TypeScript generation, tests, type check, dependency check, audit, pack, and consumer smoke test after disposable RC2 stamping - `just docs` (passes; expected Fern authentication warning skips redirect validation) - Pre-commit workflow lint and copyright checks on all changed files - Rust, Python, and Node attribution checks; dependency-license diff showed no changes #### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to) Relates to: none. This follows up on the failed Rust and TypeScript publication jobs triggered by `v0.2.0-rc.1`. - [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license. - [x] I searched existing issues and open pull requests, and this does not duplicate existing work. ## Summary by CodeRabbit * **Release Process** * Improved Rust package publishing reliability with locked dependency checks and availability verification before dependent releases. * Added dedicated Cargo version management for release workflows. * Refined prerelease and release-tag handling for beta and RC versions. * Improved release command safety when processing tag values. * **Documentation** * Updated release guidance to clarify stable versions, prerelease metadata, and tag-based workflows. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Ajay Thorve (https://github.com/AjayThorve) URL: #242
Author
|
SUCCESS - forward-merge complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/0.2 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.