Skip to content

ci: run TypeScript publishing from reusable workflows #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 2 commits into from
Aug 19, 2026
+4 −4
Merged

ci: run TypeScript publishing from reusable workflows #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7b6c8f
ci: publish TypeScript prereleases with dedicated tags
AjayThorve Aug 18, 2026
064930c
ci: keep RC npm releases on next
AjayThorve Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/publish_typescript.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ defaults:
jobs:
publish-typescript:
name: Publish (npmjs.com)
if: ${{ github.event_name == 'workflow_call' || github.ref_type == 'tag' }}
runs-on: ubuntu-24.04
timeout-minutes: 15
permissions:
Expand Down
7 changes: 4 additions & 3 deletions tests/scripts/test_publish_typescript_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@ def test_typescript_publisher_accepts_an_explicit_tag_ref():
assert not _tag_triggers_workflow("v0.3.0-alpha.20260817", tag_patterns)

job = workflow["jobs"]["publish-typescript"]
assert job["if"] == (
"${{ github.event_name == 'workflow_call' || github.ref_type == 'tag' }}"
)
assert "if" not in job

steps = {step["name"]: step for step in job["steps"]}
assert steps["Checkout"]["with"]["ref"] == "${{ inputs.ref || github.ref }}"
Expand All @@ -57,6 +55,9 @@ def test_typescript_publisher_accepts_an_explicit_tag_ref():
assert steps["Prepare release metadata"]["env"]["RELEASE_TAG"] == (
"${{ steps.source.outputs.tag }}"
)
release_metadata = steps["Prepare release metadata"]["run"]
assert '*-alpha*) dist_tag="alpha"' in release_metadata
assert '*-beta*|*-rc*) dist_tag="next"' in release_metadata


def test_nightly_alpha_calls_typescript_publisher_for_created_tag():
Expand Down
Loading