-
Notifications
You must be signed in to change notification settings - Fork 15
feat: add Pi harness adapter #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
763d686
feat: add Pi SDK adapter POC
AnuradhaKaruppiah b0f545d
feat: add Pi code review example
AnuradhaKaruppiah 141ca89
refactor: organize TypeScript adapters
AnuradhaKaruppiah 9639de6
feat: complete Pi SDK adapter integration
AnuradhaKaruppiah ea6971b
fix: address Pi adapter review feedback
AnuradhaKaruppiah 1786acd
ci: build TypeScript contract before adapter tests
AnuradhaKaruppiah e67ebb5
fix: enforce stable Node runtime for Pi
AnuradhaKaruppiah 45256d5
docs: clarify code review Relay example
AnuradhaKaruppiah c82523a
Merge upstream main into ak-pi-adapter
AnuradhaKaruppiah 8fc698c
ci: exclude generated skill artifacts from checks
AnuradhaKaruppiah 0a57eb7
feat: separate Pi adapter and harness dependencies
AnuradhaKaruppiah 496336c
fix: make Pi setup reproducible
AnuradhaKaruppiah cd713c6
docs: describe TypeScript adapter source roles
AnuradhaKaruppiah cc20344
docs: explain TypeScript lifecycle host
AnuradhaKaruppiah 856d21e
feat: add code review skill overrides
AnuradhaKaruppiah ffdf719
test: isolate Deep Agents skill selection
AnuradhaKaruppiah 3f8ae99
fix: validate TypeScript adapter release dependencies
AnuradhaKaruppiah 7318268
docs: address Pi adapter review feedback
AnuradhaKaruppiah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,131 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| name: Publish TypeScript adapter package | ||
|
|
||
| on: | ||
| push: | ||
| tags: | ||
| - 'npm/nemo-fabric-adapters-common/v*' | ||
| - 'npm/nemo-fabric-adapters-pi/v*' | ||
|
|
||
| concurrency: | ||
| group: publish-typescript-adapter-${{ github.ref }} | ||
| cancel-in-progress: false | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: bash | ||
|
|
||
| jobs: | ||
| publish-typescript-adapter: | ||
| name: Publish adapter (npmjs.com) | ||
| runs-on: ubuntu-24.04 | ||
| timeout-minutes: 25 | ||
| permissions: | ||
| contents: read | ||
| id-token: write # Required for npm trusted-publishing OIDC token issuance. | ||
| environment: npmjs | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Verify release tag | ||
| id: source | ||
| env: | ||
| RELEASE_REF: ${{ github.ref }} | ||
| run: | | ||
| set -euo pipefail | ||
| if [[ "$RELEASE_REF" != refs/tags/* ]]; then | ||
| echo "Release ref must be a tag: ${RELEASE_REF}" >&2 | ||
| exit 1 | ||
| fi | ||
| release_tag="${RELEASE_REF#refs/tags/}" | ||
| tag_commit="$(git rev-parse --verify "refs/tags/${release_tag}^{commit}")" | ||
| head_commit="$(git rev-parse HEAD)" | ||
| if [[ "$tag_commit" != "$head_commit" ]]; then | ||
| echo "Release tag ${release_tag} does not match the checked-out commit" >&2 | ||
| exit 1 | ||
| fi | ||
| echo "tag=${release_tag}" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6 | ||
| with: | ||
| node-version: '24' | ||
| package-manager-cache: false | ||
|
|
||
| - name: Install just | ||
| uses: taiki-e/install-action@c070f87102a1c75b3183910f391c1cb887fe13c8 # v2.77.6 | ||
| with: | ||
| tool: just@1.50.0 | ||
|
|
||
| - name: Validate trusted publishing toolchain | ||
| run: | | ||
| set -euo pipefail | ||
| node --version | ||
| npm_version="$(npm --version)" | ||
| echo "$npm_version" | ||
| NPM_VERSION="$npm_version" node <<'NODE' | ||
| const actual = process.env.NPM_VERSION.split('.').map(Number); | ||
| const minimum = [11, 5, 1]; | ||
| const comparison = actual.findIndex( | ||
| (part, index) => part !== minimum[index], | ||
| ); | ||
| if ( | ||
| actual.length !== minimum.length || | ||
| actual.some(Number.isNaN) || | ||
| (comparison !== -1 && actual[comparison] < minimum[comparison]) | ||
| ) { | ||
| throw new Error('npm 11.5.1 or newer is required for trusted publishing'); | ||
| } | ||
| NODE | ||
|
|
||
| - name: Resolve package release | ||
| id: release | ||
| env: | ||
| RELEASE_TAG: ${{ steps.source.outputs.tag }} | ||
| run: | | ||
| set -euo pipefail | ||
| case "$RELEASE_TAG" in | ||
| npm/nemo-fabric-adapters-common/v*) package_name="nemo-fabric-adapters-common" ;; | ||
| npm/nemo-fabric-adapters-pi/v*) package_name="nemo-fabric-adapters-pi" ;; | ||
| *) echo "Unsupported TypeScript adapter tag: $RELEASE_TAG" >&2; exit 1 ;; | ||
| esac | ||
| version="$(python3 scripts/ci/normalize_release_tag.py "${RELEASE_TAG##*/}")" | ||
| if [[ "$version" == *+* ]]; then | ||
| echo "npm publication does not support build metadata: $version" >&2 | ||
| exit 1 | ||
| fi | ||
| case "$version" in | ||
| *-alpha*) dist_tag="alpha" ;; | ||
| *-beta*|*-rc*) dist_tag="next" ;; | ||
| *-*) echo "Unsupported npm prerelease: $version" >&2; exit 1 ;; | ||
| *) dist_tag="latest" ;; | ||
| esac | ||
| python3 scripts/ci/set_typescript_adapter_version.py "$package_name" "$version" | ||
| package_directory="adapters/typescript/${package_name##nemo-fabric-adapters-}" | ||
| { | ||
| echo "package_name=$package_name" | ||
| echo "package_directory=$package_directory" | ||
| echo "version=$version" | ||
| echo "dist_tag=$dist_tag" | ||
| } >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Test adapter packages | ||
|
AnuradhaKaruppiah marked this conversation as resolved.
|
||
| run: just test-typescript-adapters | ||
|
|
||
| - name: Preflight and publish adapter package | ||
| env: | ||
| NPM_CONFIG_REGISTRY: https://registry.npmjs.org | ||
| RELEASE_VERSION: ${{ steps.release.outputs.version }} | ||
| RELEASE_DIST_TAG: ${{ steps.release.outputs.dist_tag }} | ||
| PACKAGE_DIRECTORY: ${{ steps.release.outputs.package_directory }} | ||
| run: | | ||
| set -euo pipefail | ||
| python3 scripts/ci/publish_typescript_package.py \ | ||
| --package-directory "$PACKAGE_DIRECTORY" \ | ||
| --version "$RELEASE_VERSION" \ | ||
| --dist-tag "$RELEASE_DIST_TAG" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.