Skip to content

Remove work-around for a Relay bug that has been fixed - #32

Merged
dagardner-nv merged 1 commit into
NVIDIA:mainfrom
dagardner-nv:david-remove-relay-work-around
Jul 6, 2026
Merged

Remove work-around for a Relay bug that has been fixed#32
dagardner-nv merged 1 commit into
NVIDIA:mainfrom
dagardner-nv:david-remove-relay-work-around

Conversation

@dagardner-nv

@dagardner-nv dagardner-nv commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Improved shutdown behavior so the relay gateway stops more reliably instead of waiting for queued relay events to finish flushing.
    • Reduced the chance of shutdown delays or hangs when closing the CLI integration.

Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv self-assigned this Jul 6, 2026
@dagardner-nv dagardner-nv added the enhancement New feature or request label Jul 6, 2026
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 7b99c6db-b1a5-4cc7-b9f8-bc0ef78608f2

📥 Commits

Reviewing files that changed from the base of the PR and between 6f9ab09 and 440e228.

📒 Files selected for processing (1)
  • adapters/codex-cli/src/nemo_fabric_adapters/codex_cli/adapter.py
💤 Files with no reviewable changes (1)
  • adapters/codex-cli/src/nemo_fabric_adapters/codex_cli/adapter.py
📜 Recent review details
⏰ Context from checks skipped due to timeout. (3)
  • GitHub Check: Build and publish docs
  • GitHub Check: Test
  • GitHub Check: Test

Walkthrough

The Codex CLI adapter's relay shutdown logic was modified to remove a 5-second workaround delay (RELAY-399) that previously occurred before stopping the nemo-relay gateway process, causing the gateway to be stopped immediately.

Changes

Relay Shutdown Timing

Layer / File(s) Summary
Remove pre-shutdown delay
adapters/codex-cli/src/nemo_fabric_adapters/codex_cli/adapter.py
Removed the RELAY-399 workaround comment and time.sleep(5) call that previously delayed stop_relay_gateway(relay_gateway_process); the gateway is now stopped without waiting.

Estimated code review effort: 1 (Trivial) | ~3 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Title check ❌ Error The title is relevant, but it does not use the required Conventional Commits format with a lowercase type prefix. Rename it to a Conventional Commit, for example: "fix(relay): remove workaround for fixed relay bug".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

@dagardner-nv
dagardner-nv merged commit 899a40e into NVIDIA:main Jul 6, 2026
5 checks passed
@dagardner-nv
dagardner-nv deleted the david-remove-relay-work-around branch July 6, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants