Adopt skills from NeMo Relay - #34
Conversation
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
|
📖 Fern docs preview: https://nvidia-preview-pull-request-34.docs.buildwithfern.com/nemo/fabric |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📜 Recent review details
|
| Layer / File(s) | Summary |
|---|---|
PR template and preparation guidance .github/pull_request_template.md, .agents/skills/prepare-pr/SKILL.md |
New PR template defines Overview/Details/Where-to-review/Related-Issues sections; matching skill doc instructs use of the template, PR checklist, and Conventional Commit titles. |
Contribution and coding guidance .agents/skills/contribute-api/SKILL.md, .agents/skills/contribute-docs/SKILL.md, .agents/skills/small-fix/SKILL.md, .agents/skills/karpathy-guidelines/SKILL.md |
New skill docs define workflows for adding public API surfaces, updating documentation, making narrowly-scoped bug fixes, and general coding behavior guidance. |
CI, packaging, and validation guidance .agents/skills/maintain-ci/SKILL.md, .agents/skills/maintain-packaging/SKILL.md, .agents/skills/validate-change/SKILL.md |
New skill docs define standards for CI workflow permissions/caching, packaging/release consistency checks, and a change-shape-driven validation command matrix. |
Doc style review skill and reference assets .agents/skills/review-doc-style/SKILL.md, .agents/skills/review-doc-style/assets/nvidia-style-*.md |
New skill defines a documentation-style review flow with severity-based findings, backed by four NVIDIA style reference documents (brand/terminology, general style, language mechanics, technical docs). |
README and getting-started tweaks README.md, docs/getting-started/overview.mdx |
README adds uv as a Hermes SDK prerequisite; getting-started overview reorders the cargo PATH export to precede just build-all. |
Estimated code review effort: 2 (Simple) | ~15 minutes
Suggested labels: documentation
Important
Pre-merge checks failed
Please resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check | ❌ Error | The title is relevant to the change, but it does not follow the required Conventional Commits format. | Rename it to Conventional Commits style, e.g. docs: adopt skills from NeMo Relay or another matching type/scope summary. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.agents/skills/karpathy-guidelines/SKILL.md:
- Around line 61-67: The fenced plan example in SKILL.md needs markdown-lint
fixes: add a language hint to the code fence and separate the fenced block from
the surrounding sentence with blank lines. Update the “For multi-step tasks,
state a brief plan” example so the block is a proper fenced code sample, keeping
the numbered steps inside the fence and ensuring the surrounding prose is spaced
correctly to satisfy MD031 and MD040.
In `@docs/getting-started/overview.mdx`:
- Around line 67-81: The quick start block is not fully executable because it
calls just build-all before ~/.cargo/bin is added to PATH, and it also misses
the uv prerequisite used by build-python. Update the overview instructions so
the PATH export happens before any just invocation, and add uv to the
setup/prerequisites alongside just in the quick start sequence. Use the existing
just build-all and export PATH steps as the anchor points when reordering and
extending the snippet.
In `@docs/package.json`:
- Around line 5-7: The docs package is pinned to a non-existent fern-api
release, so update the fern-api dependency in package.json to an actually
published version that matches an available npm release. Use the existing
fern-api version already used elsewhere in the repo if applicable, and make sure
the docs install path (npm install / just docs) can resolve the dependency
successfully.
In `@README.md`:
- Around line 60-75: The quick start currently isn’t runnable because `just
build-all` depends on `uv`, and the `PATH` update for Cargo binaries happens too
late. Update the README quick start so the environment setup (including
exporting Cargo bin in PATH) comes before any `just` invocation, and either add
`uv` to the prerequisites or change the later Python-related steps to use `uv
run`; use the `just build-all` and install/setup section to keep the flow
correct on a clean machine.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 54106b69-167f-49c3-996a-e2a4b590e2f0
⛔ Files ignored due to path filters (1)
docs/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (23)
.agents/skills/contribute-api/SKILL.md.agents/skills/contribute-docs/SKILL.md.agents/skills/karpathy-guidelines/SKILL.md.agents/skills/maintain-ci/SKILL.md.agents/skills/maintain-packaging/SKILL.md.agents/skills/prepare-pr/SKILL.md.agents/skills/review-doc-style/SKILL.md.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md.agents/skills/review-doc-style/assets/nvidia-style-guide.md.agents/skills/review-doc-style/assets/nvidia-style-language-mechanics.md.agents/skills/review-doc-style/assets/nvidia-style-technical-docs.md.agents/skills/small-fix/SKILL.md.agents/skills/validate-change/SKILL.md.github/pull_request_template.md.github/workflows/ci_python.yml.github/workflows/ci_rust.yml.github/workflows/fern-docs.yml.gitignoreREADME.mddocs/getting-started/overview.mdxdocs/package.jsonexamples/README.mdjustfile
📜 Review details
⚠️ CI failures not shown inline (8)
GitHub Actions: Rust / Test: Adopt skills from NeMo Relay
Conclusion: failure
##[group]Run bail() {
�[36;1mbail() {�[0m
�[36;1m printf '::error::install-action: %s\n' "$*"�[0m
GitHub Actions: Rust / 0_Test.txt: Adopt skills from NeMo Relay
Conclusion: failure
##[group]Run bail() {
�[36;1mbail() {�[0m
�[36;1m printf '::error::install-action: %s\n' "$*"�[0m
GitHub Actions: Rust / Test: Adopt skills from NeMo Relay
Conclusion: failure
##[group]Run just test-rust
�[36;1mjust test-rust�[0m
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
CARGO_INCREMENTAL: 0
CARGO_PROFILE_DEV_DEBUG: 0
CARGO_TERM_COLOR: always
RUST_BACKTRACE: short
RUSTFLAGS: -D warnings
CARGO_UNSTABLE_SPARSE_REGISTRY: true
CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
CACHE_ON_FAILURE: false
##[endgroup]
cargo test --workspace --locked
�[1m�[92m Compiling�[0m fabric-core v0.1.0 (/home/runner/work/NeMo-Fabric/NeMo-Fabric/crates/fabric-core)
�[1m�[92m Compiling�[0m fabric-cli v0.1.0 (/home/runner/work/NeMo-Fabric/NeMo-Fabric/crates/fabric-cli)
�[1m�[92m Finished�[0m `test` profile [unoptimized] target(s) in 5.53s
�[1m�[92m Running�[0m unittests src/main.rs (target/debug/deps/fabric-c3572a4d481471cf)
running 0 tests
�[1m�[92m Running�[0m unittests src/lib.rs (target/debug/deps/fabric_core-9b081566c1d472c1)
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
running 45 tests
test config::tests::errors_for_unknown_manifest_profile ... ok
GitHub Actions: Python / 0_Test.txt: Adopt skills from NeMo Relay
Conclusion: failure
##[group]Run bail() {
�[36;1mbail() {�[0m
�[36;1m printf '::error::install-action: %s\n' "$*"�[0m
GitHub Actions: Python / Test: Adopt skills from NeMo Relay
Conclusion: failure
##[group]Run bail() {
�[36;1mbail() {�[0m
�[36;1m printf '::error::install-action: %s\n' "$*"�[0m
GitHub Actions: Fern Docs / Build and publish docs: Borrow additional skills from Relay
Conclusion: failure
##[group]Run bail() {
�[36;1mbail() {�[0m
�[36;1m printf '::error::install-action: %s\n' "$*"�[0m
GitHub Actions: Fern Docs / 0_Build and publish docs.txt: Borrow additional skills from Relay
Conclusion: failure
##[group]Run bail() {
�[36;1mbail() {�[0m
�[36;1m printf '::error::install-action: %s\n' "$*"�[0m
GitHub Actions: Fern Docs / Build and publish docs: Borrow additional skills from Relay
Conclusion: failure
##[group]Run set -euo pipefail
�[36;1mset -euo pipefail�[0m
�[36;1mpr_number="${GITHUB_REF_NAME#pull-request/}"�[0m
�[36;1mif output="$(npx --prefix docs --no-install fern generate --docs --preview --id "pull-request-${pr_number}" 2>&1)"; then�[0m
�[36;1m fern_exit=0�[0m
�[36;1melse�[0m
�[36;1m fern_exit=$?�[0m
�[36;1mfi�[0m
�[36;1mprintf '%s\n' "$output"�[0m
�[36;1mif [ "$fern_exit" -ne 0 ]; then�[0m
�[36;1m echo "::error::Fern docs preview generation failed"�[0m
🧰 Additional context used
📓 Path-based instructions (18)
.github/pull_request_template.md
📄 CodeRabbit inference engine (.agents/skills/prepare-pr/SKILL.md)
When opening or editing a pull request, use
.github/pull_request_template.mdas the source of truth for the PR body and preserve its headings, checkbox intent, and related-issue guidance.
Files:
.github/pull_request_template.md
docs/package.json
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Keep documentation tooling metadata in
docs/package.jsonaligned with the documentation build and install commands.
Files:
docs/package.json
{docs/**,README.md,AGENTS.md}
⚙️ CodeRabbit configuration file
{docs/**,README.md,AGENTS.md}: Review documentation for technical accuracy against the current API, command correctness, and consistency with generated schemas.
Files:
docs/package.jsondocs/getting-started/overview.mdxREADME.md
.github/workflows/*.{yml,yaml}
📄 CodeRabbit inference engine (.agents/skills/maintain-ci/SKILL.md)
.github/workflows/*.{yml,yaml}: Putpermissions:on each GitHub Actions job that needs token access, instead of relying on broader defaults.
Avoid workflow-levelpermissions:unless the repository intentionally centralizes them and the inheritance tradeoff is documented.
Keep third-party GitHub Actions pinned to full commit SHAs and preserve the readable version comment after the SHA.
Prefer action-native or ecosystem-native caching over genericactions/cache.
Use lockfiles or dependency manifests to drive cache invalidation.
Keep deploy and publish permissions isolated to the jobs that need them.
When a workflow usesworkflow_call, read both the caller and callee; the caller must grant every permission the called jobs require, and the callee cannot elevate beyond what the caller provides.
For checkout-based build, test, docs, and packaging jobs,contents: readis the default minimum permission.
Usepull-requests: readfor jobs that look up pull request metadata.
Limitpages: writeandid-token: writeto Pages deployment jobs and any caller that invokes them through a reusable workflow.
Preferastral-sh/setup-uvcache support withcache-dependency-globanchored touv.lock.
PreferSwatinem/rust-cachewith explicitshared-keyandworkspacesinstead of ad hoctarget-directorycaching.
Avoid caching generated outputs that can hide stale behavior unless the repository already relies on them deliberately.
Files:
.github/workflows/ci_rust.yml.github/workflows/fern-docs.yml.github/workflows/ci_python.yml
{justfile,.github/workflows/*.{yml,yaml}}
📄 CodeRabbit inference engine (.agents/skills/maintain-ci/SKILL.md)
Keep local commands aligned with the corresponding
justfilerecipes when they provide equivalent behavior.
Files:
.github/workflows/ci_rust.yml.github/workflows/fern-docs.ymljustfile.github/workflows/ci_python.yml
.github/workflows/{ci_python.yml,ci_rust.yml}
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Keep CI workflow install commands, package names, and build/test steps aligned with the local packaging workflow.
Files:
.github/workflows/ci_rust.yml.github/workflows/ci_python.yml
.github/workflows/fern-docs.yml
📄 CodeRabbit inference engine (.agents/skills/maintain-ci/SKILL.md)
Keep documentation publish and preview credentials isolated to the Fern docs workflow.
Files:
.github/workflows/fern-docs.yml
**/*.{md,mdx,yml,yaml}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Keep package names, repo references, and build commands current
Capitalize NVIDIA correctly in all user-facing documentation.
Files:
examples/README.mddocs/getting-started/overview.mdxREADME.md
**/examples/**/README.md
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Update relevant example README files when examples change
Files:
examples/README.md
**/*.{md,markdown,mdx}
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Update release-facing documentation, examples, and usage text when public packaging changes affect install, import, or build commands.
Files:
examples/README.mddocs/getting-started/overview.mdxREADME.md
**/README.md
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/SKILL.md)
Update entry-point documentation where users naturally look first, including top-level and nested README files.
Files:
examples/README.mdREADME.md
**/*.{md,mdx}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/SKILL.md)
**/*.{md,mdx}: Format commands, code elements, expressions, file names, and paths as inline code where needed.
Use title case for technical-document headings.
Use descriptive anchor text instead of raw URLs or vague labels like "here".
Prefer active voice, present tense, short sentences, and plain English.
Keep terminology consistent throughout a document and avoid switching terms for the same concept.
Write procedures as imperative, parallel steps and split long sequences into smaller tasks.
Prefer "after" over "once" when describing sequence, and use "can" instead of "may" when the meaning is possibility rather than permission.
Avoid forcing trademark symbols in learning-oriented docs unless the source document explicitly requires them.
**/*.{md,mdx}: Always spellNVIDIAin all caps; do not useNvidia,nvidia,nVidia,nVIDIA, orNV.
Usean NVIDIAbefore a noun because the name starts with an "en" sound.
Do not add a registered trademark symbol afterNVIDIAwhen referring to the company.
Use trademark symbols with NVIDIA product names only when the document type or legal guidance requires them.
Verify official capitalization, spacing, and hyphenation for NVIDIA product names.
Precede NVIDIA product names withNVIDIAon first mention when it is natural and accurate.
Link the first mention of a product name when the destination helps the reader.
Do not rewrite product names for grammar or title-case rules.
Preserve third-party product names according to the owner's spelling.
Include the company name and full model qualifier on first use when it helps identify the model.
Preserve the official capitalization and punctuation of model names.
Use shorter family names only after the full model name is established.
Do not force trademark symbols unless the source, platform, or legal guidance explicitly requires them.
Keep product names accurate and consistent.
Follow the current NVIDIA trademark and copyright guidance.
Attribute trademarks on first us...
Files:
examples/README.mddocs/getting-started/overview.mdxREADME.md
**/*.md
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
**/*.md: SpellNVIDIAin all caps; do not useNvidia,nvidia, orNV.
Format commands, code elements, expressions, package names, file names, and paths as inline code.
Use descriptive link text and avoid raw URLs or weak anchors such as "here" or "read more."
Use title case consistently for technical documentation headings.
Introduce code blocks, lists, tables, and images with complete sentences.
Write procedures as imperative steps, keep steps parallel, and split long procedures into smaller tasks.
Prefer active voice, present tense, short sentences, contractions, and plain English.
Usecanfor possibility and reservemayfor permission.
Useafterfor temporal relationships instead ofonce.
Preferrefer tooverseewhen the wording points readers to another resource.
Avoid culture-specific idioms, unnecessary Latinisms, jokes, and marketing exaggeration in technical docs.
Spell out months in body text, avoid ordinal dates, and use clear time zones.
Spell out whole numbers from zero through nine unless they are technical values, parameters, versions, or UI values.
Use numerals for 10 or greater and include commas in thousands.
Do not add trademark symbols to learning-oriented docs unless the source, platform, or legal guidance explicitly requires them.
**/*.md: Use title case consistently in technical documentation headings.
Avoid quotation marks, ampersands, and exclamation marks in technical documentation headings.
Keep product, event, research, and whitepaper names in their official title case.
Use title case for table headers.
Do not force social-media sentence case into technical documentation.
Introduce every code block with a complete sentence.
Do not make a code block complete the grammar of the previous sentence.
Do not continue a sentence after a code block.
Use syntax highlighting when the format supports it.
Avoid the word "snippet" unless the surrounding documentation already uses it as a term of art.
Keep inline method, function...
Files:
examples/README.mdREADME.md
{adapters/**,examples/**}
⚙️ CodeRabbit configuration file
{adapters/**,examples/**}: Review adapter and example changes for command correctness, config/schema consistency, artifact handling, and compatibility with the public Fabric contracts.
Files:
examples/README.md
docs/**/*.{md,mdx}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Update relevant getting-started or reference docs when changes affect those user-facing docs
Files:
docs/getting-started/overview.mdx
**/*.mdx
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Use JSX comment delimiters
{/* ... */}for top-of-file SPDX comments in MDX files, and do not use HTML comments for those headersUse
{/* ... */}for top-of-file MDX SPDX comments instead of HTML comment delimiters.
Files:
docs/getting-started/overview.mdx
justfile
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Keep
justfilebuild, test, clean, and documentation recipes aligned with the current package names, install commands, and build outputs.
Files:
justfile
README.md
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Update
README.mdwhen an entry point changes
Files:
README.md
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:07.654Z
Learning: Start from the shared Rust core behavior first when adding or changing a public API surface.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:07.654Z
Learning: Decide whether the CLI, PyO3 binding, Python SDK, type stubs, schemas, or adapter contract must expose the new surface.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:07.654Z
Learning: Keep every affected public surface in parity.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:07.654Z
Learning: Update docs and examples in the same branch.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:07.654Z
Learning: The public behavior introduced or changed by the API must be clearly described.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:07.654Z
Learning: Every affected public surface must be covered.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:07.654Z
Learning: The validation matrix must match the changed surfaces.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:07.654Z
Learning: PR notes must explain the user-facing change.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:26.680Z
Learning: Prefer the documented public API, not internal shortcuts
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:26.680Z
Learning: Run `just docs` when the docs site changed
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:34.075Z
Learning: Before implementing, state assumptions explicitly and ask for clarification if uncertain.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:34.075Z
Learning: If multiple interpretations exist, present them instead of silently choosing one.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:34.075Z
Learning: If a simpler approach exists, say so and push back when warranted.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:34.075Z
Learning: If something is unclear, stop, name what is confusing, and ask.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:34.075Z
Learning: Implement only the minimum code needed to solve the requested problem; do not add features beyond what was asked.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:34.075Z
Learning: Do not add abstractions for single-use code, unrequested flexibility/configurability, or error handling for impossible scenarios.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:34.075Z
Learning: If the solution is overly large or complex, rewrite it to be simpler.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:34.075Z
Learning: When editing existing code, touch only what is necessary for the request; do not improve unrelated code, comments, or formatting.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:34.075Z
Learning: Do not refactor code that is not broken, and match the existing style even if you would prefer a different style.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:34.075Z
Learning: If unrelated dead code is noticed, mention it rather than deleting it.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:34.075Z
Learning: Remove imports, variables, and functions that your own changes made unused.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:34.075Z
Learning: Do not remove pre-existing dead code unless asked.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:34.075Z
Learning: Every changed line should trace directly to the user's request.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:34.075Z
Learning: Transform tasks into verifiable goals and define success criteria before implementing.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:34.075Z
Learning: For multi-step tasks, state a brief plan with each step and its verification check.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:34.075Z
Learning: Use strong, testable success criteria so you can iterate independently; avoid vague goals like 'make it work' without clarification.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:29:52.975Z
Learning: Keep package names, import paths, module names, generated artifacts, and workspace/Python versions internally consistent across the release surface.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: Use `karpathy-guidelines` alongside this skill for implementation or review work, and keep changes scoped, surface assumptions, and define focused validation before editing.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: Use this guidance at the end of a contributor or maintainer change before opening a pull request, and whenever creating, opening, publishing, updating, or editing a NeMo Fabric pull request or PR body.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: If this repo-local guidance conflicts with generic GitHub publishing, connector, or plugin guidance, this guidance wins for PR body format, validation language, and review handoff details.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: Ensure the branch scope is coherent and reviewable.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: Run the relevant tests under `validate-change` before opening the pull request.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: Format all changed files with the language-native formatter.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: For any Rust change, run `just test-rust`.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: For any Rust change, run `cargo fmt --all -- --check`.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: For native binding changes, run `cargo check -p fabric-python --locked`.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: If `crates/fabric-core` changes, run both the Rust and Python test suites.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: Update docs and examples for any public behavior changes.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: Update dependent maintainer or consumer skills when code changes affect their APIs, bindings, commands, paths, packaging guidance, or best practices.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: Use Conventional Commit style for pull request titles: `<type>: <concise imperative summary>`.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: Choose the Conventional Commit type from the actual change surface; use `fix` only for actual user-facing or runtime/product code bug fixes, and never for chores, CI configuration, docs, tests, packaging metadata, generated-output handling, or agent/skill guidance.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: Do not use a generic `Summary / Why / Validation` PR body unless the current repository template uses those headings.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: When using GitHub CLI, prefer `gh pr create --template .github/pull_request_template.md`.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: If a tool cannot consume the PR template directly, build the PR body from the template content and fill in every visible section before opening the PR; do not replace the template with a freeform summary.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: After creating or editing a pull request, fetch the rendered PR body and verify that the template's visible headings and checklist items are still present.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: The PR body must include `#### Overview` with a concise summary and both contribution confirmation checklist items preserved.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: The PR body must include `#### Details` with the concrete changes made.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: The PR body must include `#### Validation` with commands run and any checks not run.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: The PR body must include `#### Where should the reviewer start?` with the most useful file, test, or design decision.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: The PR body must include `#### Related Issues` using one of `Closes`, `Fixes`, `Resolves`, or `Relates to`, with an issue reference or `Relates to: none` when there is no related issue.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: Only check the contribution confirmation boxes when they are true; if either confirmation cannot be made, stop before opening the pull request and surface the blocker.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:04.112Z
Learning: Read the references `README.md`, `.github/pull_request_template.md`, and `validate-change` when preparing a PR.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:18.071Z
Learning: Review NeMo Fabric documentation, examples, and public-facing text for NVIDIA technical-writing style, terminology, repository accuracy, and current public behavior.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:18.071Z
Learning: Prioritize factual accuracy over copy polish.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:18.071Z
Learning: Flag stale commands, package names, APIs, bindings, repo paths, and support claims before stylistic issues.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:18.071Z
Learning: Keep docs aligned with current NeMo Fabric behavior, repository layout, and entry points.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:18.071Z
Learning: Use `assets/nvidia-style-guide.md` first, then open only the focused support document needed for the issue under review.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:18.071Z
Learning: Report findings in severity order with file references and concrete rewrites.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:37.678Z
Learning: Verify the technical claim against the current repository, public API, or documented command before reviewing style.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:37.678Z
Learning: Run the fast-path checklist in this file before opening the detailed support documents.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:37.678Z
Learning: Open only the support document that matches the ambiguity or finding, and load the smallest document that can answer the question.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:37.678Z
Learning: Report findings by severity and include a concrete rewrite or direction.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:37.678Z
Learning: Avoid style-only findings when the current wording is clear, accurate, and consistent with nearby docs.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:30:56.228Z
Learning: Do not flag formal conjunctive adverbs automatically; flag them only when the sentence becomes stiff, long, or harder to translate.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:09.838Z
Learning: Reproduce or identify the failing behavior first
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:09.838Z
Learning: Keep the change as small as possible
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:09.838Z
Learning: Avoid opportunistic refactors unless they are required to fix the bug safely
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:09.838Z
Learning: Add or update the smallest meaningful test that proves the fix
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: Format changed files with the language-native formatter before the final test pass.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: If Rust code changed, run `cargo fmt --all -- --check` and `just test-rust`.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: If Python code or a Python-facing adapter changed, run `just test-python`.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: If `crates/fabric-core` changed in a way exposed through Python, run both the Rust and Python suites.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: If the PyO3 bridge or package metadata changed, run `just build-python` and `cargo check -p fabric-python --locked`.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: If public configuration types changed, confirm the schema snapshot tests in `just test-rust` pass and review generated schema diffs.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: If an adapter or integration changed, run its focused tests or smoke path in addition to the language suite.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: If documentation or examples changed, run `just docs` when practical and verify documented commands against the current repository.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: If code changes alter APIs, commands, paths, packaging behavior, telemetry semantics, or documented best practices, update dependent maintainer skills in the same branch.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: If Rust core, CLI, or shared runtime semantics changed, run Rust formatting and tests; add Python tests when the behavior is exposed through the SDK, and run relevant CLI smoke tests for CLI behavior.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: If the Python SDK or PyO3 binding changed, use `python-tests`, run focused pytest tests first, then run `just test-python`; rebuild with `just build-python` when native code or packaging changed.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: If adapter behavior changed, run the focused adapter tests under `tests/`, then `just test-python`; add the dependency-free smoke path when launch, environment, or lifecycle behavior changed.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: If Harbor integration changed, run `tests/test_harbor_runner.py`, relevant Python integration smokes, and `just test-python`.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: If schema or public contract changed, run both language suites and review changes under `schemas/` and generated API references.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: If the change is documentation-only, use `contribute-docs` and `review-doc-style`; run `just docs` for docs-site or generated-reference changes.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: If CI or packaging changed, use `maintain-ci` or `maintain-packaging`, then run the recipes and checks whose behavior changed.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: Use `.github/workflows/ci_python.yml` as the source of truth for the dependency-free smoke list.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: Gated integration smokes require their documented credentials, sibling checkouts, services, or Docker environment; do not report them as run unless those prerequisites were present.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: Before review or handoff, verify README and docs entry points still match current package names and paths.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: Before review or handoff, verify examples use current `just` recipes and public commands.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: Before review or handoff, call out checks that were not run and why.
Learnt from: CR
Repo: NVIDIA/NeMo-Fabric
Timestamp: 2026-07-06T21:31:21.007Z
Learning: Before review or handoff, run `git diff --check`.
🪛 LanguageTool
.agents/skills/review-doc-style/assets/nvidia-style-technical-docs.md
[style] ~95-~95: To elevate your writing, try using an alternative expression here.
Context: ...ntences. Use bulleted lists when order does not matter. Use numbered lists when order matters ...
(MATTERS_RELEVANT)
[style] ~142-~142: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... for file extensions, such as .tgz. - Use uppercase without a period for file typ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~143-~143: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...a period for file types, such as TGZ. - Use footnotes sparingly except in research ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~144-~144: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...apers or platforms that require them. - Use the same term for the same concept thro...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
.agents/skills/review-doc-style/assets/nvidia-style-language-mechanics.md
[style] ~110-~110: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... specifications, UI values, and time. - Use commas in thousands, such as 1,397. -...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~133-~133: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...and 6G as standard technical terms. - Use px for pixels when writing dimensions...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~139-~139: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...mma in a list of three or more items. - Use commas after introductory phrases when ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~139-~139: To elevate your writing, try using a synonym here.
Context: ...es when the sentence would otherwise be hard to parse. - Use semicolons sparingly. P...
(HARD_TO)
[style] ~140-~140: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nce would otherwise be hard to parse. - Use semicolons sparingly. Prefer two senten...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~152-~152: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...f code, formulas, or literal strings. - Use square brackets for .conf stanzas or ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~153-~153: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...r code when the syntax requires them. - Use em dashes without spaces to set off par...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~154-~154: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...hen commas or parentheses are weaker. - Use en dashes for numeric, date, and page r...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~155-~155: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...s for numeric, date, and page ranges. - Use hyphens for compound modifiers before n...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
.agents/skills/maintain-ci/SKILL.md
[uncategorized] ~17-~17: The official name of this software platform is spelled with a capital “H”.
Context: .... Use this skill when a change touches .github/workflows/*.yml or `.github/workflows/...
(GITHUB)
[uncategorized] ~17-~17: The official name of this software platform is spelled with a capital “H”.
Context: ...ge touches .github/workflows/*.yml or .github/workflows/*.yaml, or when reviewing CI...
(GITHUB)
.agents/skills/prepare-pr/SKILL.md
[uncategorized] ~67-~67: The official name of this software platform is spelled with a capital “H”.
Context: ... ## Opening A Pull Request Always use .github/pull_request_template.md as the source...
(GITHUB)
.agents/skills/karpathy-guidelines/SKILL.md
[style] ~21-~21: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ..., present them - don't pick silently. - If a simpler approach exists, say so. Push...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~30-~30: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... No abstractions for single-use code. - No "flexibility" or "configurability" that...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~31-~31: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nfigurability" that wasn't requested. - No error handling for impossible scenarios...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
.agents/skills/validate-change/SKILL.md
[style] ~26-~26: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...pter changed, run just test-python. - If crates/fabric-core changed in a way e...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[uncategorized] ~95-~95: The official name of this software platform is spelled with a capital “H”.
Context: ...--fmt --check git diff --check ``` Use .github/workflows/ci_python.yml as the source ...
(GITHUB)
.agents/skills/review-doc-style/assets/nvidia-style-guide.md
[style] ~51-~51: To elevate your writing, try using a synonym here.
Context: ...d NVIDIA, unformatted command that is hard to read. | | Should fix | Clear style o...
(HARD_TO)
[style] ~89-~89: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...NeMo Fabric learning docs by default. - Do not replace precise technical terms wit...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~90-~90: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...r words when precision would be lost. - Do not flag passive voice when the actor i...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~91-~91: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... or the action is the important part. - Do not rewrite API names, package names, c...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~92-~92: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nd flags, or code literals for style. - Do not report a style issue without a conc...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
🪛 markdownlint-cli2 (0.22.1)
.github/pull_request_template.md
[warning] 1-1: First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
.agents/skills/karpathy-guidelines/SKILL.md
[warning] 62-62: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
[warning] 62-62: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
README.md
[warning] 64-64: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
🔇 Additional comments (23)
.github/pull_request_template.md (1)
1-18: 📐 Maintainability & Code Quality | ⚡ Quick winAdd the missing
Validationblock and a real no-issue fallback.
prepare-prrequires a#### Validationsection and a clearRelates to: nonepath, but this template omits both, so contributors cannot fill the PR body without hand-editing it.🛠️ Proposed fix
#### Details <!-- Describe the changes made in this PR. --> +#### Validation + +<!-- List the commands you ran and any checks you could not run. --> + #### Where should the reviewer start? <!-- Point to the most important file, test, or design decision. --> #### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to) -- Closes # +- Relates to: noneSource: Path instructions
.agents/skills/prepare-pr/SKILL.md (1)
1-108: LGTM!.agents/skills/contribute-api/SKILL.md (1)
1-40: LGTM!.agents/skills/contribute-docs/SKILL.md (1)
1-42: LGTM!.agents/skills/small-fix/SKILL.md (1)
1-38: LGTM!.agents/skills/maintain-ci/SKILL.md (1)
1-98: LGTM!.agents/skills/maintain-packaging/SKILL.md (1)
1-54: LGTM!.agents/skills/validate-change/SKILL.md (1)
1-118: LGTM!justfile (1)
1-76: LGTM!examples/README.md (1)
22-29: LGTM!.github/workflows/ci_python.yml (3)
46-50: LGTM!
91-94: 🩺 Stability & Availability
just test-pythonalready uses the project.venv. The recipe syncs into.venvand then runsuv run --no-sync pytest, so there isn’t a separate test environment to reuse.> Likely an incorrect or invalid review comment.
54-59: 🎯 Functional CorrectnessDrop the PyYAML warning.
pyyamlis already pulled in by thetest,harbor, andhermesdependency groups, souv sync --group test --extra harbor --extra hermes --extra relaystill installs it forsmoke_hermes_config_mapping.> Likely an incorrect or invalid review comment..github/workflows/ci_rust.yml (2)
36-40: LGTM!
59-62: 🗄️ Data Integrity & IntegrationNo action needed:
just test-rustalready runscargo test --workspace --locked, so this job still covers the full workspace and lockfile drift..github/workflows/fern-docs.yml (2)
34-38: LGTM!Also applies to: 76-76
55-65: 🩺 Stability & AvailabilityNo action needed
just docsalready runsnpm ci --prefix docs --ignore-scriptsbefore the workflow reaches thenpx --prefix docs --no-installpublish/preview steps, sodocs/node_modulesis populated in time.> Likely an incorrect or invalid review comment..gitignore (1)
18-18: LGTM!.agents/skills/review-doc-style/SKILL.md (1)
1-120: LGTM!.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md (1)
1-103: LGTM!.agents/skills/review-doc-style/assets/nvidia-style-guide.md (1)
1-102: LGTM!.agents/skills/review-doc-style/assets/nvidia-style-language-mechanics.md (1)
1-172: LGTM!.agents/skills/review-doc-style/assets/nvidia-style-technical-docs.md (1)
32-37: 📐 Maintainability & Code Quality | ⚡ Quick winFix the table examples so they match the guidance.
The command example should keep only the command in code formatting, and the UI-navigation row should describe
>as a chevron separator rather than angle brackets.Suggested rewrite
-| Code elements, commands, parameters, package names, expressions | Monospace | Flag prose such as "run just test-rust" and rewrite as `run just test-rust`. | -| Menu paths | Angle brackets between UI labels | Example: Select **File** > **Save As**. | +| Code elements, commands, parameters, package names, expressions | Monospace | Flag prose such as `run just test-rust` and rewrite as `run \`just test-rust\``. | +| Menu paths | Chevron separators between UI labels | Example: Select **File** > **Save As**. |Source: Coding guidelines
Signed-off-by: David Gardner <dagardner@nvidia.com>
…kills Signed-off-by: David Gardner <dagardner@nvidia.com>
2 participants
justfilefor build & test automation #33Summary by CodeRabbit