Skip to content

Drop the unused telemetry.mode config #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnuradhaKaruppiah merged 3 commits into from
Jul 9, 2026
Merged

Drop the unused telemetry.mode config #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d4a7a4
Drop the unused telemetry.mode config
dagardner-nv Jul 8, 2026
a6657f7
Merge branch 'main' of github.com:NVIDIA/NeMo-Fabric into david-drop-…
dagardner-nv Jul 9, 2026
2043f4b
Fix merge error
dagardner-nv Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion adapters/codex-cli/src/nemo_fabric_adapters/codex_cli/adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,6 @@ def run_codex(payload: dict[str, Any]) -> dict[str, Any]:
)
output["relay_runtime"] = {
"enabled": True,
"mode": os.environ.get("FABRIC_RELAY_MODE"),
"config_path": os.environ.get("FABRIC_RELAY_CONFIG_PATH"),
"emitter": "nemo-relay",
}
Expand Down
1 change: 0 additions & 1 deletion adapters/hermes-cli/src/nemo_fabric_adapters/hermes_cli/adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ def run_hermes_cli(payload: dict[str, Any]) -> dict[str, Any]:
relay_artifacts = common_utils.collect_relay_artifacts(relay_plugin_config)
output["relay_runtime"] = {
"enabled": True,
"mode": os.environ.get("FABRIC_RELAY_MODE"),
"config_path": os.environ.get("FABRIC_RELAY_CONFIG_PATH"),
"emitter": "hermes.observability/nemo_relay",
}
Expand Down
1 change: 0 additions & 1 deletion adapters/hermes-sdk/src/nemo_fabric_adapters/hermes_sdk/adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ async def run_hermes_sdk(payload: dict[str, Any]) -> dict[str, Any]:
if relay_plugin_config is not None:
output["relay_runtime"] = {
"enabled": True,
"mode": os.environ.get("FABRIC_RELAY_MODE"),
"config_path": os.environ.get("FABRIC_RELAY_CONFIG_PATH"),
"emitter": "hermes.observability/nemo_relay",
}
Expand Down
6 changes: 0 additions & 6 deletions crates/fabric-core/src/runtime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ use crate::config::{
use crate::error::{FabricError, Result};

static NEXT_ID: AtomicU64 = AtomicU64::new(1);
const RELAY_RUNTIME_MODE: &str = "sdk";
#[cfg(test)]
static TEST_STOPPED_AGENTS: Mutex<Vec<String>> = Mutex::new(Vec::new());

Expand Down Expand Up @@ -1683,7 +1682,6 @@ fn prepare_relay_runtime_config(
"schema_version": "fabric.relay/v1alpha1",
"relay": {
"enabled": true,
"mode": RELAY_RUNTIME_MODE,
"project": telemetry.relay_project.clone(),
"output_dir": telemetry
.relay_output_dir
Expand Down Expand Up @@ -1721,10 +1719,6 @@ fn prepare_relay_runtime_config(
path: path.clone(),
env: BTreeMap::from([
("FABRIC_RELAY_ENABLED".to_string(), "true".to_string()),
(
"FABRIC_RELAY_MODE".to_string(),
RELAY_RUNTIME_MODE.to_string(),
),
(
"FABRIC_RELAY_CONFIG_PATH".to_string(),
path.to_string_lossy().into_owned(),
Expand Down
1 change: 0 additions & 1 deletion tests/e2e/test_hermes_e2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ async def test_artifacts(self):
assert output["base_url"] == f"{self.api_server}/v1"
assert output["error"] is None
assert output["relay_runtime"]["enabled"] is True
assert output["relay_runtime"]["mode"] == "sdk"
assert output["relay_runtime"]["emitter"] == "hermes.observability/nemo_relay"
assert output["failed"] is False

Expand Down
Loading