-
Notifications
You must be signed in to change notification settings - Fork 15
chore: Remove the hermes_cli adapter, rename the hermes_sdk adapter to hermes
#59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rapids-bot
merged 25 commits into
NVIDIA:main
from
dagardner-nv:david-hermes-agent-adapter
Jul 14, 2026
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
2432a84
Remove hermes-cli adapter
dagardner-nv 8238060
Remove references to hermes-cli
dagardner-nv d58e22a
Rename hermes-sdk to just hermes
dagardner-nv b121f88
Update references
dagardner-nv f64cf17
Update references
dagardner-nv 30af6c4
Update lock files
dagardner-nv bd71cbe
Remove unused helper methods
dagardner-nv 878a3d7
Move methods from the hermes helper module to either the hermes adapt…
dagardner-nv 0a76c22
Move tests, remove unused fixtures
dagardner-nv 3cc1972
Combine Base and concreete classes as there is now only a single herm…
dagardner-nv 0bae327
Merge branch 'main' of github.com:NVIDIA/NeMo-Fabric into david-herme…
dagardner-nv 50edfb5
Fix merge error
dagardner-nv 07551ba
Remove sys.path manipulation
dagardner-nv 2bd7f61
Import codex_cli directly
dagardner-nv 428bb67
Remove unused path manipulation
dagardner-nv e4b9157
Fix adapter name
dagardner-nv 08cc690
Removed orphan file from merge error
dagardner-nv 20bb7ac
The config requires url and transport, doesn't support command
dagardner-nv ce74c32
Fix reference to hermes
dagardner-nv 1bd2fe1
Restore timeout value
dagardner-nv 165f598
Clean up venv instructions
dagardner-nv 98436e6
Replace hand-coded fake classes with MagicMock
dagardner-nv 1efac58
Drop pass-thru method
dagardner-nv d394246
Don't number the variants
dagardner-nv b9f98d9
Fix import order
dagardner-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
235 changes: 0 additions & 235 deletions
235
adapters/common/src/nemo_fabric_adapters/common/hermes.py
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.