(retriever) Add ingest batch and ingest inprocess commands to the new 'nr' cli command#1500
Draft
jdye64 wants to merge 6 commits intoNVIDIA:mainfrom
Draft
(retriever) Add ingest batch and ingest inprocess commands to the new 'nr' cli command#1500jdye64 wants to merge 6 commits intoNVIDIA:mainfrom
jdye64 wants to merge 6 commits intoNVIDIA:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename CLI entrypoint from
retrievertonrand addingestsubcommandsRenames the pip-installed CLI command from
retrievertonrand introduces a newnr ingestcommand group withbatchandinprocesssubcommands that expose the full ingestion pipelines directly from the CLI.Changes
CLI entrypoint rename (
retriever→nr)[project.scripts]inpyproject.tomlso the installed command isnrinstead ofretriever.README.md,HANDOFF.md), YAML configs, Python docstrings/comments, and tests withinnemo_retriever/to usenr.New
nr ingestcommand groupnr ingest batch <input-path>— Wraps the existing Ray-based batch pipeline (examples/batch_pipeline.py) with all its options (Ray cluster, actor counts, GPU allocation, recall evaluation, etc.).nr ingest inprocess <input-path>— New CLI for the in-process pipeline (no Ray required). Supports all extraction, embedding, VDB upload, and execution options:--extract-text,--extract-tables,--extract-charts,--extract-infographics,--use-table-structure,--table-output-format,--inference-batch-size, remote endpoint URLs--embed-model-name,--embed-invoke-url,--embed-modality,--embed-granularity, modality overrides--lancedb-uri,--lancedb-table,--hybrid,--overwrite--parallel,--max-workers,--gpu-devices,--page-chunk-size,--show-progress--output-dirfor JSON resultsFiles changed (24 files, +366 / −67)
pyproject.toml,adapters/cli/main.pyingest_modes/inprocess_cli.pyREADME.md,harness/HANDOFF.mdingest-config.yaml,pdf_stage_config.yaml,chart_stage_config.yaml,table_stage_config.yaml,infographic_stage_config.yaml,embedding_stage_config.yamlbatch_pipeline.py,online_pipeline.py,audio/cli.py,audio/stage.py,html/__main__.py,txt/__main__.py,vector_store/stage.py,local/stages/stage1_pdf_extraction.py,stage5_text_embeddings.py,stage6_vdb_upload.py,stage7_vdb_query.py,stage999_post_mortem_analysis.pytest_audio_stage.pyUsage examples
Test plan
nr --helpshowsingestas a subcommandnr ingest --helpshowsbatchandinprocesssubcommandsnr ingest batch --helpshows all batch pipeline optionsnr ingest inprocess --helpshows all inprocess pipeline optionsnr harness,nr pdf,nr local, etc.) still worknr --versionstill worksChecklist