Skip to content

Comments

Staging#264

Closed
mgrafu wants to merge 2 commits intomainfrom
staging
Closed

Staging#264
mgrafu wants to merge 2 commits intomainfrom
staging

Conversation

@mgrafu
Copy link
Collaborator

@mgrafu mgrafu commented Apr 2, 2025

What does this PR do ?

Merge Hindi ITN updates

Before your PR is "Ready for review"

Pre checks:

  • Have you signed your commits? Use git commit -s to sign.
  • Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • Remove import guards (try import: ... except: ...) if not already done.
  • If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • New Feature
  • Bugfix
  • Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

shiralal and others added 2 commits February 28, 2025 11:34
* Addition of whitelist and word classes

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Updation of Jenkins date

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* Cleanup

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* Updation

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* Updation

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* Future implementations for date

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* pushing rough date code for ref

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* Future implementations date.py

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* Cleanup

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Updation of Jenkinsfile

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* Telephone.py-hindi itn

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Telephone.py - Hindi ITN

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Telephone modified tagger and verbalizer

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* telephone tagger with 3,4,5 digit std codes

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* Further additions - telephone.py

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Jenkins update

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* Telephone.py

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Updated tagger-telephone.py

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* Telephone and Jenkinsfile cleanup

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Tarushi V <tarushiv@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@anand-nv anand-nv closed this Apr 3, 2025
@anand-nv anand-nv deleted the staging branch April 3, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants