Skip to content

Comments

add base coverage for fr tn date#267

Merged
tbartley94 merged 2 commits intostaging_fr_tn_datefrom
fr_tn_dates_v1
Apr 7, 2025
Merged

add base coverage for fr tn date#267
tbartley94 merged 2 commits intostaging_fr_tn_datefrom
fr_tn_dates_v1

Conversation

@mgrafu
Copy link
Collaborator

@mgrafu mgrafu commented Apr 7, 2025 •
edited
Loading

What does this PR do ?

Adds French TN date class

Before your PR is "Ready for review"

Pre checks:

  • Have you signed your commits? Use git commit -s to sign.
  • Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • Remove import guards (try import: ... except: ...) if not already done.
  • If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • New Feature
  • Bugfix
  • Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

mgrafu and others added 2 commits April 7, 2025 10:55
@mgrafu
add base coverage for fr tn date
37ab9be 
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
629476b 
for more information, see https://pre-commit.ci
@mgrafu mgrafu changed the base branch from main to staging_fr_tn_date April 7, 2025 18:01
@mgrafu mgrafu requested review from tbartley94 and zoobereq April 7, 2025 18:01
tbartley94
tbartley94 approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@tbartley94 tbartley94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbartley94 tbartley94 merged commit 73ed2ea into staging_fr_tn_date Apr 7, 2025
6 checks passed
mgrafu added a commit that referenced this pull request Apr 7, 2025
@mgrafu @pre-commit-ci
add base coverage for fr tn date (#267)
1908a76 
* add base coverage for fr tn date

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
mgrafu added a commit that referenced this pull request Apr 7, 2025
@mgrafu @pre-commit-ci
add base coverage for fr tn date (#267) (#269)
171de10 
* add base coverage for fr tn date



* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
hmlee245 pushed a commit to hmlee245/NeMo-text-processing that referenced this pull request May 13, 2025
@mgrafu @pre-commit-ci @hmlee245
add base coverage for fr tn date (NVIDIA#267) (NVIDIA#269)
fc81e64 
* add base coverage for fr tn date

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: hmlee245 <hmlee245@gmail.com>
ngachchi pushed a commit to ngachchi/NeMo-text-processing that referenced this pull request Jun 23, 2025
@mgrafu @pre-commit-ci @ngachchi
add base coverage for fr tn date (NVIDIA#267) (NVIDIA#269)
ea29828 
* add base coverage for fr tn date

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
FredHaa pushed a commit to FredHaa/NeMo-text-processing that referenced this pull request Aug 15, 2025
@mgrafu @pre-commit-ci
add base coverage for fr tn date (NVIDIA#267) (NVIDIA#269)
eaea4f7 
* add base coverage for fr tn date



* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
folivoramanh pushed a commit to folivoramanh/NeMo-text-processing that referenced this pull request Oct 13, 2025
@mgrafu @pre-commit-ci @folivoramanh
add base coverage for fr tn date (NVIDIA#267) (NVIDIA#269)
2eaf19a 
* add base coverage for fr tn date

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: folivoramanh <palasek182@gmail.com>
bbae0312 pushed a commit to bbae0312/NeMo-text-processing that referenced this pull request Oct 27, 2025
@mgrafu @pre-commit-ci @bbae0312
add base coverage for fr tn date (NVIDIA#267) (NVIDIA#269)
daafd7e 
* add base coverage for fr tn date

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Jinwoo Bae <34386414+bbae0312@users.noreply.github.com>
Rajanv307 pushed a commit to RajanPutty/NeMo-text-processing that referenced this pull request Jan 6, 2026
@mgrafu @pre-commit-ci @RajanPutty
add base coverage for fr tn date (NVIDIA#267) (NVIDIA#269)
d30258f 
* add base coverage for fr tn date

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: RajanPutty <rputty@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbartley94 tbartley94 tbartley94 approved these changes

@zoobereq zoobereq Awaiting requested review from zoobereq

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgrafu @tbartley94