Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asr warnings #10469

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Fix asr warnings #10469

wants to merge 20 commits into from

Conversation

nithinraok
Copy link
Collaborator

What does this PR do ?

Replaces deprecated cuda.amp.autocast with amp.autocast(**Args)

Collection: All (majorly ASR, TTS, Audio)

Changelog

  • replace cuda.amp.autocast with amp.autocast(**Args)

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Nithin Rao Koluguri added 4 commits September 10, 2024 08:28
Signed-off-by: Nithin Rao Koluguri <nithinraok>
1
Signed-off-by: Nithin Rao Koluguri <nithinraok>
Signed-off-by: Nithin Rao Koluguri <nithinraok>
Signed-off-by: Nithin Rao Koluguri <nithinraok>
titu1994
titu1994 previously approved these changes Sep 11, 2024
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks for the amp cleanup !

Nithin Rao Koluguri and others added 8 commits September 16, 2024 10:12
Signed-off-by: Nithin Rao Koluguri <nithinraok>
1
Signed-off-by: Nithin Rao Koluguri <nithinraok>
Signed-off-by: Nithin Rao Koluguri <nithinraok>
Signed-off-by: Nithin Rao Koluguri <nithinraok>
Signed-off-by: Nithin Rao Koluguri <nithinraok>
Signed-off-by: Nithin Rao Koluguri <nithinraok>
stevehuang52
stevehuang52 previously approved these changes Sep 16, 2024
Copy link
Collaborator

@stevehuang52 stevehuang52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix~!

Nithin Rao Koluguri added 2 commits September 17, 2024 06:00
Signed-off-by: Nithin Rao Koluguri <nithinraok>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants