Romeyn/sampler #10525
Merged
Romeyn/sampler #10525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| Returns: | ||
| MegatronStep: The potentially modified MegatronStep object. | ||
| """ |
Check notice
Code scanning / CodeQL
Statement has no effect Note
|
|
||
| Args: | ||
| step (MegatronStep): The MegatronStep object representing the current step. | ||
| """ |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| step (MegatronStep): The MegatronStep object representing the current step. | ||
| batch (DataT): The current microbatch of data being processed. | ||
| forward_callback (MegatronLossReduction): The callback for loss reduction. | ||
| """ |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| batch (DataT): The microbatch of data that was processed. | ||
| forward_callback (MegatronLossReduction): The callback for loss reduction. | ||
| output (Any): The output from the forward pass for this microbatch. | ||
| """ |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| Args: | ||
| step (MegatronStep): The MegatronStep object representing the current step. | ||
| microbatch_outputs (List[Any]): A list of outputs from all processed microbatches. | ||
| """ |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| Args: | ||
| step (MegatronStep): The MegatronStep object representing the current step. | ||
| microbatch_outputs (List[Any]): A list of outputs from all processed microbatches. | ||
| """ |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| microbatch_outputs (List[Any]): A list of outputs from all processed microbatches. | ||
| loss_reduction (MegatronLossReduction): The object used for loss reduction. | ||
| reduced (Union[torch.Tensor, Dict[str, torch.Tensor]]): The final reduced output. | ||
| """ |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| microbatch_outputs (List[Any]): A list of outputs from all processed microbatches. | ||
| reduced (Optional[Union[torch.Tensor, Dict[str, torch.Tensor]]]): The final reduced | ||
| output, if available. This may be None for certain configurations or pipeline stages. | ||
| """ |
Check notice
Code scanning / CodeQL
Statement has no effect Note
akoumpa
force-pushed
the
romeyn/sampler
branch
from
024c52e
to
109d1ef
Compare
akoumpa
force-pushed
the
romeyn/sampler
branch
3 times, most recently
from
107e0bb
to
0b31b9c
Compare
sichu2023
reviewed
Sep 23, 2024
akoumpa
force-pushed
the
romeyn/sampler
branch
from
390f454
to
a0776e2
Compare
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Marc Romeijn <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Marc Romeijn <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: akoumpa <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
akoumpa
force-pushed
the
romeyn/sampler
branch
from
d0b7732
to
85c3b1c
Compare
Signed-off-by: akoumpa <[email protected]>
rachitgarg91
pushed a commit
to rachitgarg91/NeMo
that referenced
this pull request
Sep 26, 2024
* Introducing MegatronStep to make things more extensible Signed-off-by: Alexandros Koumparoulis <[email protected]> * Improve megatron callbacks Signed-off-by: Marc Romeijn <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> * Some small fixes Signed-off-by: Marc Romeijn <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> * remove debg code Signed-off-by: Alexandros Koumparoulis <[email protected]> * add forward_only to forward backward func Signed-off-by: Alexandros Koumparoulis <[email protected]> * add global-batch-sampler support to MegatronStep Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: Marc Romeijn <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: Marc Romeijn <[email protected]> Co-authored-by: akoumpa <[email protected]> Co-authored-by: sichu <[email protected]>
maanug-nv
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Introducing MegatronStep to make things more extensible Signed-off-by: Alexandros Koumparoulis <[email protected]> * Improve megatron callbacks Signed-off-by: Marc Romeijn <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> * Some small fixes Signed-off-by: Marc Romeijn <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> * remove debg code Signed-off-by: Alexandros Koumparoulis <[email protected]> * add forward_only to forward backward func Signed-off-by: Alexandros Koumparoulis <[email protected]> * add global-batch-sampler support to MegatronStep Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: Marc Romeijn <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: Marc Romeijn <[email protected]> Co-authored-by: akoumpa <[email protected]> Co-authored-by: sichu <[email protected]>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Introducing MegatronStep to make things more extensible Signed-off-by: Alexandros Koumparoulis <[email protected]> * Improve megatron callbacks Signed-off-by: Marc Romeijn <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> * Some small fixes Signed-off-by: Marc Romeijn <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> * remove debg code Signed-off-by: Alexandros Koumparoulis <[email protected]> * add forward_only to forward backward func Signed-off-by: Alexandros Koumparoulis <[email protected]> * add global-batch-sampler support to MegatronStep Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: Marc Romeijn <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: Marc Romeijn <[email protected]> Co-authored-by: akoumpa <[email protected]> Co-authored-by: sichu <[email protected]>
tomlifu
pushed a commit
to tomlifu/NeMo
that referenced
this pull request
Oct 25, 2024
* Introducing MegatronStep to make things more extensible Signed-off-by: Alexandros Koumparoulis <[email protected]> * Improve megatron callbacks Signed-off-by: Marc Romeijn <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> * Some small fixes Signed-off-by: Marc Romeijn <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> * remove debg code Signed-off-by: Alexandros Koumparoulis <[email protected]> * add forward_only to forward backward func Signed-off-by: Alexandros Koumparoulis <[email protected]> * add global-batch-sampler support to MegatronStep Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: Marc Romeijn <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: Marc Romeijn <[email protected]> Co-authored-by: akoumpa <[email protected]> Co-authored-by: sichu <[email protected]> Signed-off-by: Lifu Zhang <[email protected]>
tomlifu
pushed a commit
to tomlifu/NeMo
that referenced
this pull request
Oct 25, 2024
* Introducing MegatronStep to make things more extensible Signed-off-by: Alexandros Koumparoulis <[email protected]> * Improve megatron callbacks Signed-off-by: Marc Romeijn <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> * Some small fixes Signed-off-by: Marc Romeijn <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> * remove debg code Signed-off-by: Alexandros Koumparoulis <[email protected]> * add forward_only to forward backward func Signed-off-by: Alexandros Koumparoulis <[email protected]> * add global-batch-sampler support to MegatronStep Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: Marc Romeijn <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: Marc Romeijn <[email protected]> Co-authored-by: akoumpa <[email protected]> Co-authored-by: sichu <[email protected]> Signed-off-by: Lifu Zhang <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* Introducing MegatronStep to make things more extensible Signed-off-by: Alexandros Koumparoulis <[email protected]> * Improve megatron callbacks Signed-off-by: Marc Romeijn <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> * Some small fixes Signed-off-by: Marc Romeijn <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> * remove debg code Signed-off-by: Alexandros Koumparoulis <[email protected]> * add forward_only to forward backward func Signed-off-by: Alexandros Koumparoulis <[email protected]> * add global-batch-sampler support to MegatronStep Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: Marc Romeijn <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: Marc Romeijn <[email protected]> Co-authored-by: akoumpa <[email protected]> Co-authored-by: sichu <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information