-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Akoumparouli/nemo ux cherrypick #10526
Open
akoumpa
wants to merge
7
commits into
r2.0.0
Choose a base branch
from
akoumparouli/nemo_ux_cherrypick
base: r2.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoumpa
force-pushed
the
akoumparouli/nemo_ux_cherrypick
branch
from
September 18, 2024 16:42
3e8bad9
to
0f85e71
Compare
akoumpa
force-pushed
the
akoumparouli/nemo_ux_cherrypick
branch
from
September 18, 2024 16:42
1051d86
to
7d6a08d
Compare
akoumpa
force-pushed
the
akoumparouli/nemo_ux_cherrypick
branch
from
September 19, 2024 19:01
85cf43e
to
6a238b9
Compare
* ci: Fix base branch of secrets detector Signed-off-by: Oliver Koenig <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]>
* [Nemo Unit Tests] Split GPU unit tests (#10380) * Split GPU unit tests * Make L0_Unit_Tests_GPU_Lightning optional since flaky * Add time for GPU_Core test * Add time for GPU_Audio test * CICD: Attempt fix for False positive (not all tests have run) (#10436) * [Nemo CICD] Make flaky test optional (#10438) * Make flaky test optional * Make flaky test optional * [Nemo CICD] Make flaky test optional (#10442) * Make flaky test optional * Make flaky test optional * Make flaky test optional * [Nemo CICD] Make flaky test optional (#10446) * Make flaky test optional * Make flaky test optional * Make flaky test optional * Make flaky test optional --------- Signed-off-by: Pablo Garay <[email protected]> * Make flaky test optional (#10448) * [Nemo CICD] Make flaky test optional (#10450) * Make flaky test optional * Make flaky test optional * [Nemo CICD] Make flaky test optional (#10452) * Make flaky test optional * Make flaky test optional * Make flaky test optional * Make flaky test optional (#10456) * Make flaky test optional (#10459) * Optional test needs optional field set true (#10475) * [Nemo CICD] Make flaky test optional (#10476) * Optional test needs optional field set true * make flaky test optional --------- Signed-off-by: Pablo Garay <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]>
* add token drop plugin Signed-off-by: Jimmy Zhang <[email protected]> * add checks Signed-off-by: Jimmy Zhang <[email protected]> * add expert parallel configs Signed-off-by: Jimmy Zhang <[email protected]> * Apply isort and black reformatting Signed-off-by: JimmyZhang12 <[email protected]> * amend comment Signed-off-by: Jimmy Zhang <[email protected]> * Apply isort and black reformatting Signed-off-by: JimmyZhang12 <[email protected]> * add comm overlap Signed-off-by: Jimmy Zhang <[email protected]> * fix rebase errors Signed-off-by: Jimmy Zhang <[email protected]> * Apply isort and black reformatting Signed-off-by: JimmyZhang12 <[email protected]> * fix typo Signed-off-by: Jimmy Zhang <[email protected]> * add test configs Signed-off-by: Jimmy Zhang <[email protected]> * fix Signed-off-by: Jimmy Zhang <[email protected]> --------- Signed-off-by: Jimmy Zhang <[email protected]> Signed-off-by: JimmyZhang12 <[email protected]> Co-authored-by: Jimmy Zhang <[email protected]> Co-authored-by: JimmyZhang12 <[email protected]> Co-authored-by: Pablo Garay <[email protected]> Co-authored-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: artbataev <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
akoumpa
force-pushed
the
akoumparouli/nemo_ux_cherrypick
branch
from
September 19, 2024 20:33
ab0e66a
to
8e934b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information