Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akoumparouli/nemo ux cherrypick #10526

Open
wants to merge 7 commits into
base: r2.0.0
Choose a base branch
from

Conversation

akoumpa
Copy link
Collaborator

@akoumpa akoumpa commented Sep 18, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

ko3n1g and others added 7 commits September 19, 2024 13:32
* ci: Fix base branch of secrets detector

Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
* [Nemo Unit Tests] Split GPU unit tests (#10380)

* Split GPU unit tests

* Make L0_Unit_Tests_GPU_Lightning optional since flaky

* Add time for GPU_Core test

* Add time for GPU_Audio test

* CICD: Attempt fix for False positive (not all tests have run) (#10436)

* [Nemo CICD] Make flaky test optional (#10438)

* Make flaky test optional

* Make flaky test optional

* [Nemo CICD] Make flaky test optional  (#10442)

* Make flaky test optional

* Make flaky test optional

* Make flaky test optional

* [Nemo CICD] Make flaky test optional (#10446)

* Make flaky test optional

* Make flaky test optional

* Make flaky test optional

* Make flaky test optional

---------

Signed-off-by: Pablo Garay <[email protected]>

* Make flaky test optional (#10448)

* [Nemo CICD] Make flaky test optional (#10450)

* Make flaky test optional

* Make flaky test optional

* [Nemo CICD] Make flaky test optional (#10452)

* Make flaky test optional

* Make flaky test optional

* Make flaky test optional

* Make flaky test optional (#10456)

* Make flaky test optional (#10459)

* Optional test needs optional field set true (#10475)

* [Nemo CICD] Make flaky test optional (#10476)

* Optional test needs optional field set true

* make flaky test optional

---------

Signed-off-by: Pablo Garay <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
* add token drop plugin

Signed-off-by: Jimmy Zhang <[email protected]>

* add checks

Signed-off-by: Jimmy Zhang <[email protected]>

* add expert parallel configs

Signed-off-by: Jimmy Zhang <[email protected]>

* Apply isort and black reformatting

Signed-off-by: JimmyZhang12 <[email protected]>

* amend comment

Signed-off-by: Jimmy Zhang <[email protected]>

* Apply isort and black reformatting

Signed-off-by: JimmyZhang12 <[email protected]>

* add comm overlap

Signed-off-by: Jimmy Zhang <[email protected]>

* fix rebase errors

Signed-off-by: Jimmy Zhang <[email protected]>

* Apply isort and black reformatting

Signed-off-by: JimmyZhang12 <[email protected]>

* fix typo

Signed-off-by: Jimmy Zhang <[email protected]>

* add test configs

Signed-off-by: Jimmy Zhang <[email protected]>

* fix

Signed-off-by: Jimmy Zhang <[email protected]>

---------

Signed-off-by: Jimmy Zhang <[email protected]>
Signed-off-by: JimmyZhang12 <[email protected]>
Co-authored-by: Jimmy Zhang <[email protected]>
Co-authored-by: JimmyZhang12 <[email protected]>
Co-authored-by: Pablo Garay <[email protected]>
Co-authored-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: artbataev <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa akoumpa force-pushed the akoumparouli/nemo_ux_cherrypick branch from ab0e66a to 8e934b0 Compare September 19, 2024 20:33
@github-actions github-actions bot added the CI label Sep 19, 2024
@akoumpa akoumpa added Run CICD and removed Run CICD labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants