Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick 10489 into r2.0.0 #10535

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

janekl
Copy link
Collaborator

@janekl janekl commented Sep 19, 2024

What does this PR do ?

Cherry pick of #10489 to r2.0.0.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@janekl janekl changed the title Update modelopt to 0.17.0 (#10489) Cherry-pick 10489 into r2.0.0 Sep 19, 2024
Signed-off-by: Jan Lasek <[email protected]>
@janekl janekl force-pushed the jlasek/modelopt_update_0_17_0_cherry_pick branch from f35f71a to 3284340 Compare September 26, 2024 08:48
@janekl janekl added Run CICD and removed Run CICD labels Sep 26, 2024
@ko3n1g ko3n1g merged commit e29e2d2 into r2.0.0 Sep 27, 2024
149 of 152 checks passed
@ko3n1g ko3n1g deleted the jlasek/modelopt_update_0_17_0_cherry_pick branch September 27, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants