Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pps issue on nemo export #10544

Merged
merged 24 commits into from
Sep 23, 2024
Merged

Conversation

oyilmaz-nvidia
Copy link
Collaborator

What does this PR do ?

Fixes an issue we see on nemo export when pps > 1

Signed-off-by: Onur Yilmaz <[email protected]>
Signed-off-by: Onur Yilmaz <[email protected]>
Signed-off-by: Onur Yilmaz <[email protected]>
@pablo-garay
Copy link
Collaborator

@pablo-garay pablo-garay merged commit c02ea12 into NVIDIA:main Sep 23, 2024
10 checks passed
ko3n1g pushed a commit that referenced this pull request Sep 23, 2024
* fix minor import bug

Signed-off-by: Onur Yilmaz <[email protected]>

* fix pps bug

* remove config file

Signed-off-by: Onur Yilmaz <[email protected]>

---------

Signed-off-by: Onur Yilmaz <[email protected]>
Co-authored-by: Shanmugam Ramasamy <[email protected]>
ko3n1g added a commit that referenced this pull request Sep 26, 2024
* fix minor import bug



* fix pps bug

* remove config file



---------

Signed-off-by: Onur Yilmaz <[email protected]>
Co-authored-by: Onur Yilmaz <[email protected]>
Co-authored-by: Shanmugam Ramasamy <[email protected]>
rachitgarg91 pushed a commit to rachitgarg91/NeMo that referenced this pull request Sep 26, 2024
* fix minor import bug

Signed-off-by: Onur Yilmaz <[email protected]>

* fix pps bug

* remove config file

Signed-off-by: Onur Yilmaz <[email protected]>

---------

Signed-off-by: Onur Yilmaz <[email protected]>
Co-authored-by: Shanmugam Ramasamy <[email protected]>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
* fix minor import bug

Signed-off-by: Onur Yilmaz <[email protected]>

* fix pps bug

* remove config file

Signed-off-by: Onur Yilmaz <[email protected]>

---------

Signed-off-by: Onur Yilmaz <[email protected]>
Co-authored-by: Shanmugam Ramasamy <[email protected]>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Oct 25, 2024
* fix minor import bug

Signed-off-by: Onur Yilmaz <[email protected]>

* fix pps bug

* remove config file

Signed-off-by: Onur Yilmaz <[email protected]>

---------

Signed-off-by: Onur Yilmaz <[email protected]>
Co-authored-by: Shanmugam Ramasamy <[email protected]>
Signed-off-by: Lifu Zhang <[email protected]>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Oct 25, 2024
* fix minor import bug

Signed-off-by: Onur Yilmaz <[email protected]>

* fix pps bug

* remove config file

Signed-off-by: Onur Yilmaz <[email protected]>

---------

Signed-off-by: Onur Yilmaz <[email protected]>
Co-authored-by: Shanmugam Ramasamy <[email protected]>
Signed-off-by: Lifu Zhang <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* fix minor import bug

Signed-off-by: Onur Yilmaz <[email protected]>

* fix pps bug

* remove config file

Signed-off-by: Onur Yilmaz <[email protected]>

---------

Signed-off-by: Onur Yilmaz <[email protected]>
Co-authored-by: Shanmugam Ramasamy <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants