Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default for always_save_context to True #10547

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

athitten
Copy link
Collaborator

@athitten athitten commented Sep 20, 2024

What does this PR do ?

Set the default value of always_save_context to True as its required to have the context for evaluating NeMo 2.0 ckpt as of now since we are converting it to 1.0 ckpt using this script: convert_nemo2_for_export.py to export to TRTLLM for evaluation.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@athitten athitten merged commit f351f64 into main Sep 24, 2024
155 of 158 checks passed
@athitten athitten deleted the athitten/save_context_true branch September 24, 2024 17:47
rachitgarg91 pushed a commit to rachitgarg91/NeMo that referenced this pull request Sep 26, 2024
maanug-nv pushed a commit that referenced this pull request Oct 2, 2024
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Oct 25, 2024
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Oct 25, 2024
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants