fix type error in llm collection #10552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maanug-nv
reviewed
Sep 20, 2024
add type hint Signed-off-by: He Huang (Steve) <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: He Huang (Steve) <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: He Huang (Steve) <[email protected]>
maanug-nv
approved these changes
Sep 24, 2024
rachitgarg91
pushed a commit
to rachitgarg91/NeMo
that referenced
this pull request
Sep 26, 2024
* fix type bugs Signed-off-by: stevehuang52 <[email protected]> * Update mixin.py add type hint Signed-off-by: He Huang (Steve) <[email protected]> * Apply isort and black reformatting Signed-off-by: stevehuang52 <[email protected]> * Update mixin.py Signed-off-by: He Huang (Steve) <[email protected]> * Apply isort and black reformatting Signed-off-by: stevehuang52 <[email protected]> * Update mixin.py Signed-off-by: He Huang (Steve) <[email protected]> --------- Signed-off-by: stevehuang52 <[email protected]> Signed-off-by: He Huang (Steve) <[email protected]> Signed-off-by: stevehuang52 <[email protected]> Co-authored-by: stevehuang52 <[email protected]>
maanug-nv
pushed a commit
that referenced
this pull request
Oct 2, 2024
* fix type bugs Signed-off-by: stevehuang52 <[email protected]> * Update mixin.py add type hint Signed-off-by: He Huang (Steve) <[email protected]> * Apply isort and black reformatting Signed-off-by: stevehuang52 <[email protected]> * Update mixin.py Signed-off-by: He Huang (Steve) <[email protected]> * Apply isort and black reformatting Signed-off-by: stevehuang52 <[email protected]> * Update mixin.py Signed-off-by: He Huang (Steve) <[email protected]> --------- Signed-off-by: stevehuang52 <[email protected]> Signed-off-by: He Huang (Steve) <[email protected]> Signed-off-by: stevehuang52 <[email protected]> Co-authored-by: stevehuang52 <[email protected]>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* fix type bugs Signed-off-by: stevehuang52 <[email protected]> * Update mixin.py add type hint Signed-off-by: He Huang (Steve) <[email protected]> * Apply isort and black reformatting Signed-off-by: stevehuang52 <[email protected]> * Update mixin.py Signed-off-by: He Huang (Steve) <[email protected]> * Apply isort and black reformatting Signed-off-by: stevehuang52 <[email protected]> * Update mixin.py Signed-off-by: He Huang (Steve) <[email protected]> --------- Signed-off-by: stevehuang52 <[email protected]> Signed-off-by: He Huang (Steve) <[email protected]> Signed-off-by: stevehuang52 <[email protected]> Co-authored-by: stevehuang52 <[email protected]>
tomlifu
pushed a commit
to tomlifu/NeMo
that referenced
this pull request
Oct 25, 2024
* fix type bugs Signed-off-by: stevehuang52 <[email protected]> * Update mixin.py add type hint Signed-off-by: He Huang (Steve) <[email protected]> * Apply isort and black reformatting Signed-off-by: stevehuang52 <[email protected]> * Update mixin.py Signed-off-by: He Huang (Steve) <[email protected]> * Apply isort and black reformatting Signed-off-by: stevehuang52 <[email protected]> * Update mixin.py Signed-off-by: He Huang (Steve) <[email protected]> --------- Signed-off-by: stevehuang52 <[email protected]> Signed-off-by: He Huang (Steve) <[email protected]> Signed-off-by: stevehuang52 <[email protected]> Co-authored-by: stevehuang52 <[email protected]> Signed-off-by: Lifu Zhang <[email protected]>
tomlifu
pushed a commit
to tomlifu/NeMo
that referenced
this pull request
Oct 25, 2024
* fix type bugs Signed-off-by: stevehuang52 <[email protected]> * Update mixin.py add type hint Signed-off-by: He Huang (Steve) <[email protected]> * Apply isort and black reformatting Signed-off-by: stevehuang52 <[email protected]> * Update mixin.py Signed-off-by: He Huang (Steve) <[email protected]> * Apply isort and black reformatting Signed-off-by: stevehuang52 <[email protected]> * Update mixin.py Signed-off-by: He Huang (Steve) <[email protected]> --------- Signed-off-by: stevehuang52 <[email protected]> Signed-off-by: He Huang (Steve) <[email protected]> Signed-off-by: stevehuang52 <[email protected]> Co-authored-by: stevehuang52 <[email protected]> Signed-off-by: Lifu Zhang <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* fix type bugs Signed-off-by: stevehuang52 <[email protected]> * Update mixin.py add type hint Signed-off-by: He Huang (Steve) <[email protected]> * Apply isort and black reformatting Signed-off-by: stevehuang52 <[email protected]> * Update mixin.py Signed-off-by: He Huang (Steve) <[email protected]> * Apply isort and black reformatting Signed-off-by: stevehuang52 <[email protected]> * Update mixin.py Signed-off-by: He Huang (Steve) <[email protected]> --------- Signed-off-by: stevehuang52 <[email protected]> Signed-off-by: He Huang (Steve) <[email protected]> Signed-off-by: stevehuang52 <[email protected]> Co-authored-by: stevehuang52 <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
fix type error in llm collection