Akoumparouli/nemo ux ckpt conv bugfix #10558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
akoumpa
force-pushed
the
akoumparouli/nemo_ux_ckpt_conv_bugfix
branch
from
45ceb25
to
1b549c5
Compare
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
akoumpa
force-pushed
the
akoumparouli/nemo_ux_ckpt_conv_bugfix
branch
3 times, most recently
from
d5e1802
to
7338d6f
Compare
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
akoumpa
force-pushed
the
akoumparouli/nemo_ux_ckpt_conv_bugfix
branch
from
8b57cd3
to
a9c5392
Compare
Signed-off-by: Alexandros Koumparoulis <[email protected]>
akoumpa
force-pushed
the
akoumparouli/nemo_ux_ckpt_conv_bugfix
branch
from
fb9932d
to
05b8b6c
Compare
Signed-off-by: Alexandros Koumparoulis <[email protected]>
akoumpa
force-pushed
the
akoumparouli/nemo_ux_ckpt_conv_bugfix
branch
from
7486c0f
to
9521d4f
Compare
Signed-off-by: akoumpa <[email protected]>
cuichenx
approved these changes
Sep 20, 2024
8 tasks
rachitgarg91
pushed a commit
to rachitgarg91/NeMo
that referenced
this pull request
Sep 26, 2024
* Call original _te._get_extra_te_kwargs and modify device Signed-off-by: Alexandros Koumparoulis <[email protected]> * add dtype utils Signed-off-by: Alexandros Koumparoulis <[email protected]> * Fix Llama ckpt conversion dtype Signed-off-by: Alexandros Koumparoulis <[email protected]> * propage ckpt precision changes Signed-off-by: Alexandros Koumparoulis <[email protected]> * minor improvement Signed-off-by: Alexandros Koumparoulis <[email protected]> * bot happy Signed-off-by: Alexandros Koumparoulis <[email protected]> * fix Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: akoumpa <[email protected]>
maanug-nv
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Call original _te._get_extra_te_kwargs and modify device Signed-off-by: Alexandros Koumparoulis <[email protected]> * add dtype utils Signed-off-by: Alexandros Koumparoulis <[email protected]> * Fix Llama ckpt conversion dtype Signed-off-by: Alexandros Koumparoulis <[email protected]> * propage ckpt precision changes Signed-off-by: Alexandros Koumparoulis <[email protected]> * minor improvement Signed-off-by: Alexandros Koumparoulis <[email protected]> * bot happy Signed-off-by: Alexandros Koumparoulis <[email protected]> * fix Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: akoumpa <[email protected]>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Call original _te._get_extra_te_kwargs and modify device Signed-off-by: Alexandros Koumparoulis <[email protected]> * add dtype utils Signed-off-by: Alexandros Koumparoulis <[email protected]> * Fix Llama ckpt conversion dtype Signed-off-by: Alexandros Koumparoulis <[email protected]> * propage ckpt precision changes Signed-off-by: Alexandros Koumparoulis <[email protected]> * minor improvement Signed-off-by: Alexandros Koumparoulis <[email protected]> * bot happy Signed-off-by: Alexandros Koumparoulis <[email protected]> * fix Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: akoumpa <[email protected]>
tomlifu
pushed a commit
to tomlifu/NeMo
that referenced
this pull request
Oct 25, 2024
* Call original _te._get_extra_te_kwargs and modify device Signed-off-by: Alexandros Koumparoulis <[email protected]> * add dtype utils Signed-off-by: Alexandros Koumparoulis <[email protected]> * Fix Llama ckpt conversion dtype Signed-off-by: Alexandros Koumparoulis <[email protected]> * propage ckpt precision changes Signed-off-by: Alexandros Koumparoulis <[email protected]> * minor improvement Signed-off-by: Alexandros Koumparoulis <[email protected]> * bot happy Signed-off-by: Alexandros Koumparoulis <[email protected]> * fix Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: akoumpa <[email protected]> Signed-off-by: Lifu Zhang <[email protected]>
tomlifu
pushed a commit
to tomlifu/NeMo
that referenced
this pull request
Oct 25, 2024
* Call original _te._get_extra_te_kwargs and modify device Signed-off-by: Alexandros Koumparoulis <[email protected]> * add dtype utils Signed-off-by: Alexandros Koumparoulis <[email protected]> * Fix Llama ckpt conversion dtype Signed-off-by: Alexandros Koumparoulis <[email protected]> * propage ckpt precision changes Signed-off-by: Alexandros Koumparoulis <[email protected]> * minor improvement Signed-off-by: Alexandros Koumparoulis <[email protected]> * bot happy Signed-off-by: Alexandros Koumparoulis <[email protected]> * fix Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: akoumpa <[email protected]> Signed-off-by: Lifu Zhang <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* Call original _te._get_extra_te_kwargs and modify device Signed-off-by: Alexandros Koumparoulis <[email protected]> * add dtype utils Signed-off-by: Alexandros Koumparoulis <[email protected]> * Fix Llama ckpt conversion dtype Signed-off-by: Alexandros Koumparoulis <[email protected]> * propage ckpt precision changes Signed-off-by: Alexandros Koumparoulis <[email protected]> * minor improvement Signed-off-by: Alexandros Koumparoulis <[email protected]> * bot happy Signed-off-by: Alexandros Koumparoulis <[email protected]> * fix Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: akoumpa <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Ensure checkpoint importer saves the model in the same precision as original checkpoint
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information