Alit/nemotron h #12942
Merged
Alit/nemotron h #12942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JRD971000 <[email protected]>
Signed-off-by: artbataev <[email protected]>
Signed-off-by: Ali Taghibakhshi <[email protected]>
Signed-off-by: JRD971000 <[email protected]>
Signed-off-by: Ali Taghibakhshi <[email protected]>
Signed-off-by: JRD971000 <[email protected]>
Signed-off-by: JRD971000 <[email protected]>
Signed-off-by: JRD971000 <[email protected]>
Signed-off-by: Ali Taghibakhshi <[email protected]>
Signed-off-by: Ali Taghibakhshi <[email protected]>
Signed-off-by: Ali Taghibakhshi <[email protected]>
Signed-off-by: JRD971000 <[email protected]>
|
[🤖]: Hi @JRD971000 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
yashaswikarnati
approved these changes
Apr 13, 2025
ko3n1g
pushed a commit
that referenced
this pull request
Apr 14, 2025
* add nemotron5 * add recipes * address copilot comments * Add guard to quantizer import * modify recipes for nm5 * modify test and ssm * fix HF and CS * Apply isort and black reformatting Signed-off-by: JRD971000 <[email protected]> * Apply isort and black reformatting Signed-off-by: artbataev <[email protected]> * Apply isort and black reformatting Signed-off-by: JRD971000 <[email protected]> * Update quantizer.py Signed-off-by: Ali Taghibakhshi <[email protected]> * fix tests * Apply isort and black reformatting Signed-off-by: JRD971000 <[email protected]> * fix generate * Add docstring and linting fixes * Apply isort and black reformatting Signed-off-by: JRD971000 <[email protected]> * fix linting * change mcore hash and add tests * Apply isort and black reformatting Signed-off-by: JRD971000 <[email protected]> * modify fp8 recipe in generate * Update manifest.json Signed-off-by: Ali Taghibakhshi <[email protected]> * Update manifest.json Signed-off-by: Ali Taghibakhshi <[email protected]> * Set requirements/manifest.json to match origin/main * fix typo Signed-off-by: Ali Taghibakhshi <[email protected]> * Apply isort and black reformatting Signed-off-by: JRD971000 <[email protected]> * fix docstring * Set CHANGELOG.md to match origin/main * Set examples/llm/auto_configurator/auto_config.py to match origin/main * Set nemo/collections/asr/data/audio_to_text_dataset.py to match origin/main * Set nemo/collections/llm/tools/auto_configurator/core/calculate_performance.py to match origin/main * Set nemo/collections/llm/tools/auto_configurator/core/training_config.py to match origin/main * Set nemo/collections/llm/tools/auto_configurator/runner.py to match origin/main * Set tests/collections/llm/auto_conf/test_generate_configs.py to match origin/main * recipe fix * fix recipe size: * add triton plugin * add triton plugin * fix plugin * remove triton 3.1 dependencies * add dynamo back * Add dynamo to recipe * trition cache manager to plugins * set triton version limit * add 47, 56 to nemo1->2 conversion * fix 47B HF mismatch * remove breakpoint * Apply isort and black reformatting Signed-off-by: JRD971000 <[email protected]> * resolve nemo1->2 convertor conflicts * name change to nemotron h * fix HF card * fix HF card * Apply isort and black reformatting Signed-off-by: JRD971000 <[email protected]> * add more naming fix * more renaming * update cicd test name * abv renaming * hf convertor fix for 47-56b * Apply isort and black reformatting Signed-off-by: JRD971000 <[email protected]> * more cleanups * get tokenizer from HF * make async configurable * Apply isort and black reformatting Signed-off-by: JRD971000 <[email protected]> * fix pylint * fix pytest --------- Signed-off-by: JRD971000 <[email protected]> Signed-off-by: artbataev <[email protected]> Signed-off-by: Ali Taghibakhshi <[email protected]> Co-authored-by: Ali Taghibakhshi <[email protected]> Co-authored-by: JRD971000 <[email protected]> Co-authored-by: artbataev <[email protected]> Co-authored-by: Ali Taghibakhshi <[email protected]>
chtruong814
pushed a commit
that referenced
this pull request
Apr 15, 2025
* add nemotron5 * add recipes * address copilot comments * Add guard to quantizer import * modify recipes for nm5 * modify test and ssm * fix HF and CS * Apply isort and black reformatting * Apply isort and black reformatting * Apply isort and black reformatting * Update quantizer.py * fix tests * Apply isort and black reformatting * fix generate * Add docstring and linting fixes * Apply isort and black reformatting * fix linting * change mcore hash and add tests * Apply isort and black reformatting * modify fp8 recipe in generate * Update manifest.json * Update manifest.json * Set requirements/manifest.json to match origin/main * fix typo * Apply isort and black reformatting * fix docstring * Set CHANGELOG.md to match origin/main * Set examples/llm/auto_configurator/auto_config.py to match origin/main * Set nemo/collections/asr/data/audio_to_text_dataset.py to match origin/main * Set nemo/collections/llm/tools/auto_configurator/core/calculate_performance.py to match origin/main * Set nemo/collections/llm/tools/auto_configurator/core/training_config.py to match origin/main * Set nemo/collections/llm/tools/auto_configurator/runner.py to match origin/main * Set tests/collections/llm/auto_conf/test_generate_configs.py to match origin/main * recipe fix * fix recipe size: * add triton plugin * add triton plugin * fix plugin * remove triton 3.1 dependencies * add dynamo back * Add dynamo to recipe * trition cache manager to plugins * set triton version limit * add 47, 56 to nemo1->2 conversion * fix 47B HF mismatch * remove breakpoint * Apply isort and black reformatting * resolve nemo1->2 convertor conflicts * name change to nemotron h * fix HF card * fix HF card * Apply isort and black reformatting * add more naming fix * more renaming * update cicd test name * abv renaming * hf convertor fix for 47-56b * Apply isort and black reformatting * more cleanups * get tokenizer from HF * make async configurable * Apply isort and black reformatting * fix pylint * fix pytest --------- Signed-off-by: JRD971000 <[email protected]> Signed-off-by: artbataev <[email protected]> Signed-off-by: Ali Taghibakhshi <[email protected]> Co-authored-by: Ali Taghibakhshi <[email protected]> Co-authored-by: Ali Taghibakhshi <[email protected]> Co-authored-by: JRD971000 <[email protected]> Co-authored-by: artbataev <[email protected]> Co-authored-by: Ali Taghibakhshi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information