[codex] disable unsupported OpenClaw self-update hints in sandbox#1215
[codex] disable unsupported OpenClaw self-update hints in sandbox#121513ernkastel wants to merge 4 commits intoNVIDIA:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughBuild-time config now sets Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
✨ Thanks for submitting this pull request, which proposes a way to disable unsupported OpenClaw self-update hints in sandbox. Possibly related open issues:
|
|
Temporarily closing this bundled security PR to free one contributor PR slot for the grouped cleanup PR. I’ll link the replacement PR here as soon as it is open. |
Summary
This PR stops NemoClaw sandbox images from advertising
openclaw updateas the supported upgrade path.Root cause
NemoClaw installs
openclawinto the sandbox image at build time and pins that version inDockerfile.base, but the generated sandbox config still allows OpenClaw's startup update hint. Inside the sandbox that hint tells users to runopenclaw update, which leads them into an in-container self-update flow that is not how NemoClaw images are upgraded.What changed
openclaw.jsonupdate.checkOnStarttofalseUser impact
Users inside a NemoClaw sandbox will stop seeing a misleading recommendation to run
openclaw update. The supported path remains shipping a newer pinned OpenClaw version in the image and recreating the sandbox from that image.Addresses #1029.
Validation
bash -n test/e2e-gateway-isolation.shgit diff --check./test/e2e-gateway-isolation.sh(dockeris not installed in the publishing environment)Summary by CodeRabbit
Documentation
Configuration
Tests