docs(cli): clarify OpenShell compatibility recovery#1264
docs(cli): clarify OpenShell compatibility recovery#1264WuKongAI-CMU wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughAdded documentation and CLI/test messaging clarifying that NemoClaw pins the OpenShell runtime; users must not run standalone OpenShell/NPM lifecycle or sandbox/gateway recreate commands on NemoClaw-managed deployments. Recovery guidance: back up workspace and rerun Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/get-started/quickstart.md (1)
82-86: Use an allowed MyST admonition type here.
importantis not in the allowed callout set for docs pages in this repo. Usewarning(ornote/tip) instead.Suggested diff
-:::{important} OpenShell version compatibility +:::{warning} OpenShell version compatibility Treat the OpenShell version installed or reused by NemoClaw as part of the NemoClaw release you installed. Do not run `openshell self-update`, `npm update -g openshell`, `openshell gateway start --recreate`, or `openshell sandbox create` directly for a NemoClaw-managed deployment. If you suspect an incompatible OpenShell upgrade, [back up your workspace](../workspace/backup-restore.md) and rerun `nemoclaw onboard` so NemoClaw can reinstall the expected runtime and rebuild the managed resources. :::As per coding guidelines, “Use MyST admonitions (:::{tip}, :::{note}, :::{warning}) for callouts, not bold text or blockquotes.”
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/get-started/quickstart.md` around lines 82 - 86, The MyST admonition currently uses an unsupported type "important" (the block starting with ":::important"); change it to a supported callout such as ":::warning" (or ":::note"/":::tip") so the docs lint and render correctly—update the admonition header and closing token to match (e.g., replace ":::important" ... ":::” with ":::warning" ... ":::") and keep the existing content unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/get-started/quickstart.md`:
- Around line 82-86: The MyST admonition currently uses an unsupported type
"important" (the block starting with ":::important"); change it to a supported
callout such as ":::warning" (or ":::note"/":::tip") so the docs lint and render
correctly—update the admonition header and closing token to match (e.g., replace
":::important" ... ":::” with ":::warning" ... ":::") and keep the existing
content unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d408196c-4826-4231-a563-3cb9b78c3655
📒 Files selected for processing (5)
README.mdbin/nemoclaw.jsdocs/get-started/quickstart.mddocs/reference/troubleshooting.mdtest/cli.test.js
|
✨ Thanks for submitting this pull request, which proposes a way to clarify OpenShell compatibility recovery. Possibly related open issues: |
Signed-off-by: peteryuqin <peter.yuqin@gmail.com>
Summary
Verification
Summary by CodeRabbit
Documentation
Bug Fixes
Tests