fix(k8s): document image digest pinning for production deployments#1480
fix(k8s): document image digest pinning for production deployments#1480dknos wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 5 minutes and 35 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated Kubernetes manifest to pin three container images by SHA256 digest and removed a Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@k8s/nemoclaw-k8s.yaml`:
- Line 29: Replace the mutable image tags in the k8s/nemoclaw-k8s.yaml manifest
with immutable image digests: locate the image: fields currently set to
docker:24-dind and the other two mutable tags and change them to fully qualified
references using the tag plus `@sha256`:<digest> (e.g. name:tag@sha256:...) or
split dev/prod manifests and pin only the production overlay; ensure the three
occurrences (the image: entries referenced in the comment) are updated so
deployments use the pinned digests rather than mutable tags.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 38afd286-483f-4169-8c73-eb06f57d5362
📒 Files selected for processing (2)
k8s/nemoclaw-k8s.yamlnemoclaw-blueprint/policies/presets/huggingface.yaml
60fb97f to
d24731e
Compare
|
Updated — images are now pinned by SHA256 digest. Removed out-of-scope huggingface.yaml change. |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
dknos
left a comment
There was a problem hiding this comment.
Confirmed resolved: all three container image references in k8s/nemoclaw-k8s.yaml now use @sha256: digest pinning (docker:24-dind, node:22, busybox). Comments about digest pinning have been replaced with actual pinned image fields. CodeRabbit's latest re-review marked the file as trivially changed with no actionable comments.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
d24731e to
33369d1
Compare
Pin docker:24-dind, node:22, and busybox images by digest to prevent supply chain drift from mutable tags. Fixes NVIDIA#1436 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: dknos <rneebo@gmail.com>
Discord bots rarely need DELETE access. Removing it reduces the attack surface for sandbox agents interacting with Discord APIs. Fixes NVIDIA#1433 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: dknos <rneebo@gmail.com>
33369d1 to
994e54d
Compare
Summary
:latest,:24-dind,:22can drift unexpectedly, creating supply chain riskTest plan
kubectl apply --dry-run=clientFixes #1436
🤖 Generated with Claude Code
Summary by CodeRabbit