fix(policy): update HuggingFace preset to router.huggingface.co#1481
fix(policy): update HuggingFace preset to router.huggingface.co#1481dknos wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
The api-inference.huggingface.co endpoint returns HTTP 410 (Gone). Updated to the current router.huggingface.co endpoint. Fixes NVIDIA#1453 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthroughUpdated the HuggingFace preset network policy endpoint host from the deprecated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
nemoclaw-blueprint/policies/presets/huggingface.yaml (1)
27-27: Add a hostname-specific regression test for this preset.Current tests only verify presets have endpoints, not that HuggingFace uses the expected inference host. Please add an assertion that
huggingfacepreset endpoints includerouter.huggingface.co(and optionally exclude the deprecated host) to prevent silent regressions.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@nemoclaw-blueprint/policies/presets/huggingface.yaml` at line 27, Add a focused regression test that checks the "huggingface" preset's endpoints include the hostname "router.huggingface.co" (and optionally assert it does not include the deprecated "api-inference.huggingface.co"). Implement this as a new unit test (e.g., TestHuggingFacePresetHost or add to TestPresetsEndpoints) that loads the presets map or uses the existing helper (e.g., presets["huggingface"] or GetPreset("huggingface")) and asserts the endpoints list contains "router.huggingface.co" and does not contain the deprecated host.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@nemoclaw-blueprint/policies/presets/huggingface.yaml`:
- Line 27: Add a focused regression test that checks the "huggingface" preset's
endpoints include the hostname "router.huggingface.co" (and optionally assert it
does not include the deprecated "api-inference.huggingface.co"). Implement this
as a new unit test (e.g., TestHuggingFacePresetHost or add to
TestPresetsEndpoints) that loads the presets map or uses the existing helper
(e.g., presets["huggingface"] or GetPreset("huggingface")) and asserts the
endpoints list contains "router.huggingface.co" and does not contain the
deprecated host.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d1527bbb-960b-4b26-a0e4-1c0767e86471
📒 Files selected for processing (1)
nemoclaw-blueprint/policies/presets/huggingface.yaml
Summary
api-inference.huggingface.coendpoint torouter.huggingface.coTest plan
router.huggingface.coFixes #1453
🤖 Generated with Claude Code
Summary by CodeRabbit