fix(scripts): replace GNU find -printf with POSIX basename#1484
fix(scripts): replace GNU find -printf with POSIX basename#1484dknos wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughWhen restoring without a timestamp, the script now extracts backup directory names using Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
0f1334c to
069f16a
Compare
…workspace.sh The -printf flag is GNU-specific and silently fails on macOS/BSD. Use -exec basename instead for cross-platform compatibility. Fixes NVIDIA#1431 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: dknos <rneebo@gmail.com>
069f16a to
0f077aa
Compare
Summary
find -printf '%f\n'with POSIX-compatiblefind ... -exec basename {} \;-printfis not availableTest plan
Fixes #1431
🤖 Generated with Claude Code
Summary by CodeRabbit