fix(helm): restore Kubernetes e2e chart rendering - #3692
Merged
Merged
Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
requested review from
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 25, 2026 01:00
|
Label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore Kubernetes e2e Helm installs after #3677 left an empty
supervisor.sandboxRuntimeoverride in the Skaffold values file. Helm treated it as null and failed while renderingboundaryPortin gateway config, blocking the Kubernetes jobs on #3686 before tests could start.Related Issue
No issue required: this is an obvious localized regression in the Helm CI values file introduced by #3677.
Changes
supervisor.sandboxRuntimekey and obsolete comment from the Skaffold values file so the chart's defaultboundaryPortremains available.helm:lintrender the default chart and every CI values variant, catching template errors thathelm lintalone misses.Testing
mise run pre-commitpasses.mise run helm:lintpasses and renders all CI values variants.mise run helm:testpasses (187 Helm unit tests).mise run cidid not pass locally: the Go SDK gateway tests see this host's/etc/openshell/gateways/defaultsystem entry and fail assertions that expect only test-created gateways. The Helm checks above pass.test:e2elabel; awaiting CI.Checklist