Skip to content

fix(helm): restore Kubernetes e2e chart rendering - #3692

Merged
drew merged 1 commit into
mainfrom
codex/fix-kubernetes-e2e-helm-values
Sep 25, 2026
Merged

drew merged 1 commit into
mainfrom
codex/fix-kubernetes-e2e-helm-values

Conversation

@drew

@drew drew commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

Restore Kubernetes e2e Helm installs after #3677 left an empty supervisor.sandboxRuntime override in the Skaffold values file. Helm treated it as null and failed while rendering boundaryPort in gateway config, blocking the Kubernetes jobs on #3686 before tests could start.

Related Issue

No issue required: this is an obvious localized regression in the Helm CI values file introduced by #3677.

Changes

  • Remove the empty supervisor.sandboxRuntime key and obsolete comment from the Skaffold values file so the chart's default boundaryPort remains available.
  • Make helm:lint render the default chart and every CI values variant, catching template errors that helm lint alone misses.

Testing

  • mise run pre-commit passes.
  • mise run helm:lint passes and renders all CI values variants.
  • mise run helm:test passes (187 Helm unit tests).
  • mise run ci did not pass locally: the Go SDK gateway tests see this host's /etc/openshell/gateways/default system entry and fail assertions that expect only test-created gateways. The Helm checks above pass.
  • Kubernetes e2e is requested through the test:e2e label; awaiting CI.

Checklist

  • Follows Conventional Commits.
  • Commit is signed off (DCO).
  • Architecture docs reviewed; no architecture behavior changed.

Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew drew added the test:e2e Requires end-to-end coverage label Sep 25, 2026
@drew
drew requested a review from a team as a code owner September 25, 2026 01:00
@github-actions

Copy link
Copy Markdown

Label test:e2e applied for 292b0f3. Open the existing run and click Re-run all jobs to execute with the label set. The run will execute the standard E2E suite after building the required gateway, sandbox, and supervisor images once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

@drew
drew enabled auto-merge September 25, 2026 01:31
@drew
drew disabled auto-merge September 25, 2026 01:31
@drew
drew merged commit 1374672 into main Sep 25, 2026
101 of 107 checks passed
@drew
drew deleted the codex/fix-kubernetes-e2e-helm-values branch September 25, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant