Repository navigation
fix(ocsf): record redacted command in process launch events - #5027
Open
ericcurtin wants to merge 1 commit into
Open
ericcurtin wants to merge 1 commit into
ericcurtin wants to merge 1 commit into
Conversation
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
Contributor
Author
|
@krishicks PTAL. Launch argv is on by default here, happy to gate it behind a setting if you prefer. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Launch events now record the command with redacted, bounded arguments. Network events stop showing an ancestry path list as
cmd_line.Related Issue
Closes #4563
Changes
sanitize_cmd_line_for_audit: redacts secrets, quotes and escapes arguments, keeps 64 args and 1024 chars.process.cmd_lineon launch events.cmd_linefrom network and HTTP events.[cmd:..]and the process name in shorthand logs.Release Notes
Launch events carry a redacted
process.cmd_line. Network and HTTP events no longer carrycmd_line.Testing
cargo fmt,clippy -D warnings, and tests foropenshell-ocsf,openshell-sandbox, andopenshell-supervisor-networkpass.mise run docspasses. E2E not run.Checklist