Repository navigation
feat(report): retain sanitized input acquisition origin - #1118
Conversation
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
|
Ready for review. All six hosted checks pass at |
rng1995
left a comment
There was a problem hiding this comment.
[SkillSpector Review]
Decision: Approved
Value and readiness
Saved reports can identify the acquisition target after the working directory is removed. The origin remains distinct from finding coordinates and local scan state.
Material findings
No blocking findings. The resolver attaches the origin after materialization, preserving local spelling. Report entry validates the optional state and applies the same URL projection before the four renderers. The test covers userinfo, port, query, fragments, malformed URLs, missing state and local cleanup. SARIF adds the origin in a run property bag.
PIC tradeoffs
The new fields identify the request. They carry literal local paths and URL paths and provide no content digest or resolved Git revision. The MCP outer target still echoes the caller's request, while the embedded report uses the sanitized metadata.
Verification and gaps
Reviewed the complete seven-file diff and exact-head resolver, rendering, model and CLI/MCP entry-point context. All six hosted checks passed at the reviewed SHA. The author reports working source and wheel CLI/MCP runs and OASIS SARIF schema validation. I did not rerun contributor code, tests, network acquisition, or hosted SARIF ingestion.
Reviewed head: c1444826c3db57d11787c93db980094bd50d2e3b.
Reports now retain the requested input origin and type alongside the materialized scan directory. JSON adds
skill.origin, SARIF addsruns[].properties.inputOrigin, and terminal/Markdown display the same metadata. URL userinfo, queries and fragments are omitted; literal local path spelling is preserved. Existing source fields, finding coordinates and cleanup behavior remain intact.Validation at
c1444826c3db57d11787c93db980094bd50d2e3b:Origin records the sanitized request, not a resolved revision or content digest. Local paths and URL paths remain visible; arbitrary secrets inside those paths are outside this projection. Runtime validation used no-LLM scans on macOS; live-model, Windows and customer-production behavior were not exercised. Schema validation does not establish hosted SARIF ingestion. An optional targeted mypy check retains the same two pre-existing report typing diagnostics reproduced on the base revision.
This additive metadata is separate from multi-format output selection in #1065.
Closes #1116.