Repository navigation
[#21826][fix] Name the context that can never fit in the V2 deadlock error #21827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maxwbuckley
wants to merge
1
commit into
NVIDIA:main
Choose a base branch
from
maxwbuckley:fix/v2-scheduler-replay-deadlock
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+79
−3
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: NVIDIA/TensorRT-LLM
Length of output: 19951
Script executed:
Repository: NVIDIA/TensorRT-LLM
Length of output: 42652
Script executed:
Repository: NVIDIA/TensorRT-LLM
Length of output: 16906
Base the deadlock diagnosis on the effective scheduling cost.
If an earlier request stops on KV allocation, a later request may never reach prefix preparation. Its cached prefix could make it fit, but this filter reports that it can never be scheduled and replaces the pool remedy. Encoder requests also use
encoder_output_len, notcontext_remaining_length, for scheduling.Only report requests as impossible when their effective scheduling cost establishes that conclusion. Include the corrected cause in the warning as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 3f84c40. The classification uses the scheduler's effective cost (
_uncached_tokens, net of the reusable cached prefix, plus draft tokens), skips encoder requests, keeps the pool remedy with the chunked-prefill hint appended, and puts the cause in the warning too.test_a_context_that_fits_after_prefix_reuse_is_not_namedcovers the prefix case.