Skip to content

[https://nvbugs/7054054][fix] Restore MiniMax GR100 test coverage - #21946

Draft
peihu-nv wants to merge 1 commit into
NVIDIA:mainfrom
peihu-nv:fix-m3-gr100-test-regressions
Draft

peihu-nv wants to merge 1 commit into
NVIDIA:mainfrom
peihu-nv:fix-m3-gr100-test-regressions

Conversation

@peihu-nv

@peihu-nv peihu-nv commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator

@coderabbitai summary

Description

The MiniMax GR100 tests fail because a passing attention case is still marked as a strict expected failure, and the CuTe DSL and CUTLASS MXFP8 GEMMs are compared bit-for-bit. Remove the stale expectation and compare both GEMM results with the dequantized reference using the existing certified accuracy bounds. The pinned tactic and quantization remain bitwise checked.

Removes the test waivers for NVBugs 7054054 and 7054055.

Test Coverage

  • Changed-file pre-commit checks and Python syntax checks passed.
  • GR100 post-merge test stage: pending CI validation.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@peihu-nv

peihu-nv commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "GR100-PyTorch-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #83537 [ run ] triggered by Bot. Commit: 9ce9b0c Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #83537 [ run ] completed with state SUCCESS. Commit: 9ce9b0c
/LLM/main/L0_MergeRequest_PR pipeline #69054 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@peihu-nv

peihu-nv commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast --extra-stage "GR100-PyTorch-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #83560 [ run ] triggered by Bot. Commit: 9ce9b0c Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #83560 [ run ] completed with state SUCCESS. Commit: 9ce9b0c
/LLM/main/L0_MergeRequest_PR pipeline #69074 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Signed-off-by: peihengh <259410613+peihu-nv@users.noreply.github.com>
@peihu-nv
peihu-nv force-pushed the fix-m3-gr100-test-regressions branch from 9ce9b0c to 2c85300 Compare November 10, 2026 15:33
@peihu-nv

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast --extra-stage "GR100-PyTorch-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #83828 [ run ] triggered by Bot. Commit: 2c85300 Link to invocation

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants